-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request] Display different node types with different colors #6
Comments
Good call ... thank you! The colour of Zags is based on the LQI value relating to ... In ZigZag v1 I had intended for a number of things to be user configurable, such as: I will look at adding this capability to ZigZag, initially by setting entries in the configuration.yml. |
Not sure what "available" means here? Like an end device sleeping? But if you want to keep this then you could use the following:
For fun I have been looking at the code. As I said I have no knowledge of js ts and how the things are build! https://github.com/Samantha-uk/one/blob/main/zigzag/modules/grapher/src/zig-widget.ts
I have tried to replace the color with something else but without success :O . Just changing this line does not seems sufficient |
Well actually I am probably close to what I was trying to do. I just remembered that you have to clear the browser buffers. |
In fairness ... I'm not totally sure what criteria ZHA uses to determine this! I've posted on Discord to ask.
Awesome! I first started playing with TypeScript back in June (or so). I found the learning curve to be on the steep side! Having said all of this, it has been great fun and if you are able to invest the time I suggest you may also find it an enjoyable journey. And now to the colours thing. As part of that porting effort it was suggested that I should use HA theme colours as the basis of any rendering and I did this. So colours are referred to using their home assistant name, and the actual values are loaded here https://github.com/Samantha-uk/one/blob/main/zigzag/modules/grapher/src/grapher.ts#L336-L374 As the main Zigzag code is no longer tightly coupled to HA, this should probably be refactored/moved/replaced. |
I think it's displaying black as a default for colour names it does not recognise. https://github.com/Samantha-uk/one/blob/main/zigzag/modules/render/core/src/iconhelper.ts is where the various icons are "converted" to SVG path data. JS has this ... odd (to me!) way of allowing one to access an array entry using array.entrykey or array['entrykey'] and this is being used in ZZ. |
Thanks What do you think of the proposal
|
At present I'm in the process of moving from using VSCode to NeoVim (So I'm for the moment finding it harder to navigate the Zigzag codebase), I'm running a new Mac Mini M1 and later today I'm expecting the arrival of the bits to build a 18Tb NAS (I'd like to drop my reliance on Apple Cloud & Dropbox) ... it's a busy day lol However, I'm letting the colour change idea bubble away at the back of my mind, with the following goals.
I am inclined to have the defaults as they were in Zigzagv1 I'm still undecided as to whether to assign the device type colours to the icon or to the background of the ring, need to consider an approach that also plays nicely with the 3D renderer. |
Having the capability of placing the ZigBee nodes in a floorplan is a wonderful idea :) It will help in placing adequately the routers to build a good mesh. Very exciting. Pictures above is based on running SW? or just a mockup picture? |
It was a real (but undocumented) feature of ZZv1, basically importing an image and displaying it in the background. It will most certainly appear in ZZv2 ... not sure when.
With the However, I'm not quite sure yet how best to address this in the 2D |
This is a edited copy of the configurable items from ZZv1 that will likely be the basis for ZZv2.
|
Great! For multi floorplans may be an idea would be to provide a filter based on HA Areas. |
Great idea! |
I REALLY need to add the icon/colour legend to the documentation! Zigbee endpoint info is both obscure (at times) and HUGE! (https://www.eetimes.com/zigbee-applications-part-5-addressing-within-the-node/) At present only a few of the possible endpoints are mapped to specific mini-icons in ZZv2 I imagine that moving to a config file based approach would be best, as it would allow the community to add in new icons for various endpoints (Another one to add to the Roadmap). One issue tho is actually finding suitable icons. There are some SVG icons that just won't display properly in 3D (Something to do with how they their paths are specified I think) The |
By the way @DrCoolzic ... thank you for your feedback ... it is detailed, valuable and much appreciated in helping sort out some of the annoying ZZ issues! :) |
Thanks for the documentation about Zigzag |
In deCONZ they use an XML file to describe the information for profiles and clusters look at chapter 10 of The XML file used is here https://github.com/dresden-elektronik/deconz-rest-plugin/blob/master/general.xml |
Thanks Samantha, very useful map, IMHO better than zha-map. Now I'm only suggesting a new configuration option:
I have a bunch of sonoff zigbee switches (mains powered) used for automating my Christmas lights. Thanks! |
This is another filter option :) |
Thanks for the info |
as per request #10 Device background:
Device outline:definable outline color based on floor
|
Ok another proposal (sorry changes all the time :) ) ** Device shape
** Device background color ** Hiding devices ** Shading devices |
Is there a way to disable/toggle the labels on the lines? |
You are displaying the different type of nodes with différents icons (nice), But would it be possible to the display different node type with circles of different colors. This help when you are zoom out
For example:
Coordinator in blue
Router in yellow
End-device in green
The text was updated successfully, but these errors were encountered: