Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve searching feature supporting URL as well #50

Closed
Sav22999 opened this issue Sep 29, 2023 · 4 comments · Fixed by #52 or #61
Closed

Improve searching feature supporting URL as well #50

Sav22999 opened this issue Sep 29, 2023 · 4 comments · Fixed by #52 or #61

Comments

@Sav22999
Copy link
Owner

Search: Can it be added a support to search multiple terms instead of one kewword/phrase as it is now (perhaps separated by comma)? And maybe adding the url in the searchable text?

Related to #46

Sav22999 added a commit that referenced this issue Oct 5, 2023
- Improved search feature #50
@Sav22999 Sav22999 mentioned this issue Oct 5, 2023
Merged
@Sav22999 Sav22999 linked a pull request Oct 5, 2023 that will close this issue
Merged
@Sav22999 Sav22999 added fixed and removed in progress labels Oct 5, 2023
@nik-gr
Copy link

nik-gr commented Oct 16, 2023

thanks! did you decide to not implement the multi keyword search?

@Sav22999
Copy link
Owner Author

@nik-gr You're true! I've implemented an improved searching but I forgot to implement multi-keyword search. I'll think how to implement it (a good UX, as usual, and I'll implement 😄 )

So I reopen this issue

@Sav22999 Sav22999 reopened this Oct 16, 2023
@Sav22999 Sav22999 mentioned this issue Oct 16, 2023
@Sav22999 Sav22999 linked a pull request Oct 16, 2023 that will close this issue
@nik-gr
Copy link

nik-gr commented Oct 17, 2023

Perfect! And I have to repeat what an other user wrote, it's amazing your response time :)
what I had in mind was for a note to be in the results to have all of the keywords (main reason to use search is to find a specific note), the implementation gives results of all notes that have anyone of the keywords but that's ok as well, with good choice of keywords it covers the functionality I had in mind. 👍
I think it will be nice to have tooltip explaining how to use it

For any user may reading this:
you can search for different keywords by separating them with ';'
instead of a keyword you can give a whole phrase to be matched (leading and trailing empty spaces are not ignored)
it is an OR match: if a note matches any of the keywords then it will be in the results
search for match includes the text of the note itself, the url and the title of it

@Sav22999
Copy link
Owner Author

@nik-gr I'll add a tooltip to explain the multi-keys search feature 😊 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants