Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add "Page" for all urls (also for non http(s) ones) #51

Closed
Sav22999 opened this issue Sep 29, 2023 · 0 comments · Fixed by #52
Closed

Re-add "Page" for all urls (also for non http(s) ones) #51

Sav22999 opened this issue Sep 29, 2023 · 0 comments · Fixed by #52

Comments

@Sav22999
Copy link
Owner

For non http/s urls there is no page option anymore, why? It is possible someone to want to add notes perhaps to different pages of the same addon at moz-extension://... Without the page option he won't be able to do it. I understand it is a rare case (me, I don't think I will use it) but since the functionality is already implemented and exists, why to hide it

Related to #46

Sav22999 added a commit that referenced this issue Oct 5, 2023
- Started implementing "Other sub-domains" (/a/*, /a/b/*, ecc.) --> This will be available after enabled "Advanced management" in Settings
- Enabled "Page" also for moz-extension protocol ("about" causes some issues) #51
- Disabled url-redirect for unsupported urls in All websites
@Sav22999 Sav22999 mentioned this issue Oct 5, 2023
Merged
@Sav22999 Sav22999 linked a pull request Oct 5, 2023 that will close this issue
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant