New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDF handling broken for Python 3.9+ by xml.etree API change #239

Open

elgow opened this issue Jun 7, 2023 · 1 comment

elgow commented Jun 7, 2023

The getchildren() method has been removed from xml.etree from python 3.9 (https://docs.python.org/3.8/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.getchildren)
resulting in the error

File ".../lib/python3.10/site-packages/genologics/descriptors.py", line 200, in _update_elems
for elem in self.rootnode.getchildren():
AttributeError: 'xml.etree.ElementTree.Element' object has no attribute 'getchildren'

Seems to be an easy fix as getchildren() is used in only two places

/Users/egow/.pyenv/versions/3.10.9/envs/LIMS-15796/lib/python3.10/site-packages/genologics
descriptors.py
for node2 in node.getchildren():
for elem in self.rootnode.getchildren():

PR to follow

Author

elgow commented Jul 19, 2023

Arleady resolved by commit 13199c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment