Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Ability to configure OTLP endpoint to OTLP agent running on Node host as daemonset #2656

Open
amardeep2006 opened this issue Feb 14, 2025 · 3 comments

Comments

@amardeep2006
Copy link
Contributor

amardeep2006 commented Feb 14, 2025

Feature and motivation

We have our observability collector agents running on the Kubernetes Nodes as daemonsets. The issue is that by default IP address for kubernetes node is not available to the pods. I am looking for a solution that can help me with this.
I could find out that we can inject the Node IP via helm chart like this

            - name: KUBERNETES_NODE_HOST_IP
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: status.hostIP

How do i point the exporter endpoint to this env variable via config?
I am not sure following will work. Because I feel this should also be inject via Helm only .

  - name: SE_OTEL_EXPORTER_ENDPOINT
    value: "http://$KUBERNETES_NODE_HOST_IP:4317"

I feel some changes are required to handle this.

Usage example

Ability to export traces data to OTLP endpoint on Node host.

Copy link

@amardeep2006, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@VietND96
Copy link
Member

I feel your way provided should work. However, for all components, via extraEnvironmentVariables needs to be inserted.
What do you think?

@amardeep2006
Copy link
Contributor Author

Thanks @VietND96 . I have never looked up in the details how these env variables gets applied to to the selenium server jar arguments but the logic to apply SE_OTEL_EXPORTER_ENDPOINT to selenium jars should not change at the startup script level.
It's a choice we need to make how to wire SE_OTEL_EXPORTER_ENDPOINT with KUBERNETES_NODE_HOST_IP .
Please suggest a approach you think is best to wire these and pass to all pods based on certain flag .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants