Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using translated property names is dangerous! #213

Open
bertrandgorge opened this issue Apr 17, 2023 · 3 comments
Open

Using translated property names is dangerous! #213

bertrandgorge opened this issue Apr 17, 2023 · 3 comments

Comments

@bertrandgorge
Copy link

bertrandgorge commented Apr 17, 2023 •
edited
Loading

Just for future ref, commit d2abfee broke BC, because it changed the translation of special properties. When someone use those translations in ask queries, changing them breaks everything (sesp-property-*).

Maybe a good advice to put in the documentation would be to always use the English property names in queries...
@gesinn-it-gea
Copy link
Member

what's "BC"?

@JeroenDeDauw
Copy link
Member

Backwards Compatibility

And yeah, I'm unsure if having translated property names is a good idea in the first place.

@kghbln
Copy link
Member

kghbln commented Apr 18, 2023

We could at least a a warning to https://translatewiki.net/wiki/Template:Doc-smw-sp-desc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JeroenDeDauw @kghbln @gesinn-it-gea @bertrandgorge