Request to copy some code

[SenexCrenshaw]

I am developing a SGP40 driver for esphome.
https://esphome.io/

I would like to use your algorithm in your library but including the files might interfere with esphome's license as well as our automated linting/building doesn't like your formats/naming convention.

Is there an issue with me copying the function/pieces of code that I need out of your library into my own source? There are a few of us who would love to incorporate this into esphome. Im just being sensitive to licenses.

[rnestler]

might interfere with esphome's license

Under what terms is the result licensed? The code in this repository is licensed under the terms of: https://github.com/Sensirion/embedded-sgp/blob/master/LICENSE

[rnestler]

Also: Did you see the SVM40 module already? It includes an SGP40 and SHTC3 sensor and the mentioned algorithm and is thus much easier to use. We also provide embedded and Arduino drivers for it: https://github.com/sensirion/?q=svm40

[SenexCrenshaw]

I actually read that after this post and I will include a reference back to this license in this repo. I think im good. I pushed a new PR and I know some folks are looking forward to trying this out. In case your are interested: esphome/esphome#1513

…

On Fri, Feb 5, 2021 at 11:09 AM Raphael Nestler ***@***.***> wrote: might interfere with esphome's license Under what terms is the result licensed? The code in this repository is licensed under the terms of: https://github.com/Sensirion/embedded-sgp/blob/master/LICENSE — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPTPLKXZCCI4HF2TYTKFVLS5QJ2XANCNFSM4XDPOZ4Q> .

[rnestler]

I guess we can close this issue then. Thanks for adding support for our sensors to esphome 🙂

[SenexCrenshaw]

Ah. sorry i just realized how much SVM40 code is. I will incorporate that. I would make a PR for the SVM40 but dont have access to any.. Hint hint ;)

…

On Wed, Feb 10, 2021 at 10:03 AM Raphael Nestler ***@***.***> wrote: I guess we can close this issue then. Thanks for adding support for our sensors to esphome 🙂 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPTPLNKOQLTDLUEJEDRHI3S6KN43ANCNFSM4XDPOZ4Q> .

[rnestler]

@SenexCrenshaw If you email me your postal address I can send you an SVM40 evaluation kit 🙂

[SenexCrenshaw]

@rnestler Sounds great. I tried my best but couldnt find your address.
Found ya and sent an email.

[SenexCrenshaw]

I did btw look at the new code. it is much cleaner but the mcu on that dev board handles the VOC index algorithm, right?

[rnestler]

it is much cleaner but the mcu on that dev board handles the VOC index algorithm, right?

Thanks. Correct, the MCU on the board handles the periodic measurements and the VOC index algorithm.

[SenexCrenshaw]

Cool, thank you for everything and sorry for commenting on a closed thread.