Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"timeout" arg missing for EnvArgs to instantiate BrowserEnv is missing #273

Open
rowingchenn opened this issue Nov 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rowingchenn
Copy link

Hi, I noticed some missing arguments in EnvArgs for instantiating BrowserGym with full configurations.

For example, timeout is not configurable in EnvArgs, and the timeout for context or page configuration can only be set by the attribute in the Task class this way.

As well as pw_chromium_kwargs, which is not that important but still incomplete for designing EnvArgs.

Hopefully, this is useful for your improvement! I've been deeply reading and reconstructing your codebase to do my experiments; I love your work, and thank you for continued updating:)

@gasse
Copy link
Collaborator

gasse commented Nov 25, 2024

Hi @rowingchenn , thanks for the kind words!

I'm not sure why we didn't include timeout in EnvArgs, it should be pretty easy to add. @recursix was there a reason why we didn't have it? Should we include all BrowserEnv parameters in EnvArgs ?

@gasse gasse added the enhancement New feature or request label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants