Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trade+ is broken and abandoned #115

Closed
MilesBHuff opened this issue Jul 20, 2021 · 4 comments
Closed

Trade+ is broken and abandoned #115

MilesBHuff opened this issue Jul 20, 2021 · 4 comments
Assignees
@MilesBHuff
Labels
bug Unintended or incorrect behavior that can be replicated. help needed The assignee requires assistance with this ticket.

Comments

@MilesBHuff
Copy link
Member

MilesBHuff commented Jul 20, 2021 •
edited
Loading

The /trade command is failing to bring up a UI.

I think the problem is that upstream does not yet support Java v1.16+. This is a problem, because some of our other plugins actually require Java 1.16+.

An alternative cause, is that whatever API they're using to bring up "GUI"s (PlaceholderAPI?) has had a breaking change that Trade+ is unhappy about.

Very similar or identical to #114.
@MilesBHuff MilesBHuff added the bug Unintended or incorrect behavior that can be replicated. label Jul 20, 2021
@MilesBHuff MilesBHuff mentioned this issue Jul 20, 2021
Closed
@MilesBHuff MilesBHuff added the help needed The assignee requires assistance with this ticket. label Jul 20, 2021
@MilesBHuff MilesBHuff self-assigned this Jul 20, 2021
@MilesBHuff
Copy link
Member Author

Latest version is even more broken. Filed bug report here: Trophonix/TradePlus#81

@MilesBHuff
Copy link
Member Author

MilesBHuff commented Aug 17, 2023 •
edited
Loading

Trade+ appears to be now abandoned; accordingly, we now require an alternative.

@MilesBHuff MilesBHuff changed the title Trade+ is broken Trade+ is broken and abandoned Aug 17, 2023
@MilesBHuff
Copy link
Member Author

I've gone ahead and removed Trade+. (92e1432)

@MilesBHuff MilesBHuff changed the title Trade+ is broken and abandoned Find working trade plugin May 25, 2024
@MilesBHuff MilesBHuff added feature This is a substantial change to intended behavior. and removed bug Unintended or incorrect behavior that can be replicated. help needed The assignee requires assistance with this ticket. labels May 25, 2024
@MilesBHuff MilesBHuff changed the title Find working trade plugin Trade+ is broken and abandoned May 25, 2024
@MilesBHuff MilesBHuff added bug Unintended or incorrect behavior that can be replicated. help needed The assignee requires assistance with this ticket. and removed feature This is a substantial change to intended behavior. labels May 25, 2024
@MilesBHuff
Copy link
Member Author

The replacement will be handled in #195.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MilesBHuff MilesBHuff

Labels
bug Unintended or incorrect behavior that can be replicated. help needed The assignee requires assistance with this ticket.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MilesBHuff