Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Highlight priority #1114

Open
2 tasks done
lumynou5 opened this issue Nov 30, 2024 · 0 comments
Open
2 tasks done

[REQUEST] Highlight priority #1114

lumynou5 opened this issue Nov 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lumynou5
Copy link

lumynou5 commented Nov 30, 2024

Is there an existing issue for this?

  • I have searched the existing issues

This feature does not exist in the latest nightly version

  • I have checked the latest nightly version

Feature Description

It seems the current implementation depends on the insertion order of highlight rules (#1054). This might be unwanted because it's hard to configure exact rules to apply. Two possible designs are

  • Always apply most strict rule. For example, if a message matches the conditions "from a moderator" (badge) and "from a certain user" (username), the username rule is applied due to its narrower range. It's easy to users and is the desired behavior usually but with limitation e.g. reply is wider than username but reply can be considered more important.
  • Allow users to decide the priority of each rule. We still need to decide how to handle edge cases such as multiple rules with same priority.

I'm willing to make a patch for this, but I think we should discuss the design before implementation.

@lumynou5 lumynou5 added the enhancement New feature or request label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant