From 8ba67e00ca931c999c977298c3cea73342ad849d Mon Sep 17 00:00:00 2001
From: Kevin <kevin.jablonka@epfl.ch>
Date: Fri, 21 Aug 2020 17:17:15 +0200
Subject: [PATCH 1/2] feat: added set_xy for coregionalized model

---
 GPy/models/gp_coregionalized_regression.py | 61 ++++++++++++++++++----
 1 file changed, 51 insertions(+), 10 deletions(-)

diff --git a/GPy/models/gp_coregionalized_regression.py b/GPy/models/gp_coregionalized_regression.py
index 6604f6348..c2253e900 100644
--- a/GPy/models/gp_coregionalized_regression.py
+++ b/GPy/models/gp_coregionalized_regression.py
@@ -6,6 +6,7 @@
 from .. import likelihoods
 from .. import kern
 from .. import util
+from paramz import ObsAr
 
 class GPCoregionalizedRegression(GP):
     """
@@ -28,19 +29,59 @@ class GPCoregionalizedRegression(GP):
     :param kernel_name: name of the kernel
     :type kernel_name: string
     """
-    def __init__(self, X_list, Y_list, kernel=None, likelihoods_list=None, name='GPCR',W_rank=1,kernel_name='coreg'):
 
-        #Input and Output
-        X,Y,self.output_index = util.multioutput.build_XY(X_list,Y_list)
+    def __init__(
+        self,
+        X_list,
+        Y_list,
+        kernel=None,
+        likelihoods_list=None,
+        name="GPCR",
+        W_rank=1,
+        kernel_name="coreg",
+    ):
+
+        # Input and Output
+        X, Y, self.output_index = util.multioutput.build_XY(X_list, Y_list)
         Ny = len(Y_list)
 
-        #Kernel
+        # Kernel
         if kernel is None:
-            kernel = kern.RBF(X.shape[1]-1)
-            
-            kernel = util.multioutput.ICM(input_dim=X.shape[1]-1, num_outputs=Ny, kernel=kernel, W_rank=W_rank,name=kernel_name)
+            kernel = kern.RBF(X.shape[1] - 1)
+
+            kernel = util.multioutput.ICM(
+                input_dim=X.shape[1] - 1,
+                num_outputs=Ny,
+                kernel=kernel,
+                W_rank=W_rank,
+                name=kernel_name,
+            )
+
+        # Likelihood
+        likelihood = util.multioutput.build_likelihood(
+            Y_list, self.output_index, likelihoods_list
+        )
+
+        super(GPCoregionalizedRegression, self).__init__(
+            X, Y, kernel, likelihood, Y_metadata={"output_index": self.output_index}
+        )
+
+    def set_XY(self, X=None, Y=None):
+        if isinstance(X, list):
+            X, _, self.output_index = util.multioutput.build_XY(X, None)
+        if isinstance(Y, list):
+            _, Y, self.output_index = util.multioutput.build_XY(Y, Y)
+
+        self.update_model(False)
+        if Y is not None:
+            self.Y = ObsAr(Y)
+            self.Y_normalized = self.Y
+        if X is not None:
+            self.X = ObsAr(X)
 
-        #Likelihood
-        likelihood = util.multioutput.build_likelihood(Y_list,self.output_index,likelihoods_list)
+        self.Y_metadata = {
+            "output_index": self.output_index,
+            "trials": np.ones(self.output_index.shape),
+        }
 
-        super(GPCoregionalizedRegression, self).__init__(X,Y,kernel,likelihood, Y_metadata={'output_index':self.output_index})
+        self.update_model(True)

From 3f090751b3868a5d5344c116fcb66401b3bacdd1 Mon Sep 17 00:00:00 2001
From: Kevin <kevin.jablonka@epfl.ch>
Date: Sun, 23 Aug 2020 13:40:37 +0200
Subject: [PATCH 2/2] feat: adding normalizer argument in constructor

---
 GPy/models/gp_coregionalized_regression.py | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/GPy/models/gp_coregionalized_regression.py b/GPy/models/gp_coregionalized_regression.py
index c2253e900..f628c029a 100644
--- a/GPy/models/gp_coregionalized_regression.py
+++ b/GPy/models/gp_coregionalized_regression.py
@@ -8,6 +8,7 @@
 from .. import util
 from paramz import ObsAr
 
+
 class GPCoregionalizedRegression(GP):
     """
     Gaussian Process model for heteroscedastic multioutput regression
@@ -35,6 +36,7 @@ def __init__(
         X_list,
         Y_list,
         kernel=None,
+        normalizer=None,
         likelihoods_list=None,
         name="GPCR",
         W_rank=1,
@@ -63,7 +65,12 @@ def __init__(
         )
 
         super(GPCoregionalizedRegression, self).__init__(
-            X, Y, kernel, likelihood, Y_metadata={"output_index": self.output_index}
+            X,
+            Y,
+            kernel,
+            likelihood,
+            Y_metadata={"output_index": self.output_index},
+            normalizer=normalizer,
         )
 
     def set_XY(self, X=None, Y=None):
@@ -74,8 +81,13 @@ def set_XY(self, X=None, Y=None):
 
         self.update_model(False)
         if Y is not None:
-            self.Y = ObsAr(Y)
-            self.Y_normalized = self.Y
+            if self.normalizer is not None:
+                self.normalizer.scale_by(Y)
+                self.Y_normalized = ObsAr(self.normalizer.normalize(Y))
+                self.Y = Y
+            else:
+                self.Y = ObsAr(Y)
+                self.Y_normalized = self.Y
         if X is not None:
             self.X = ObsAr(X)