Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

Translation Epic TS1 - Manage the magic strings used for translation for confirmationModal #288

Open
4 tasks done
Tracked by #261
pratimasakinala opened this issue Mar 19, 2021 · 0 comments
Open
4 tasks done
Tracked by #261
Assignees
Labels
refactor Code changes underneath the hood; no difference in user experience

Comments

@pratimasakinala
Copy link
Collaborator

pratimasakinala commented Mar 19, 2021

Desired Use Case

Manage the magic strings like confirmationModal.action in an Interface.

Actual/Current Behavior

There are a lot of hard-coded strings in the templates that are needed by transloco to perform translation on the property defined by these strings.

Steps to Implement This Feature

  • Create an interface for confirmationModal key from the JSON files.
  • Create an interface for the following first level of nested keys under confirmationModal in the language JSON files:
    • action
    • title

Testing Steps

If you are not a member of this project, skip this step

  1. Open the site.
  2. On any of the list views, select the delete action and verify that the content in the confirmation modal is displayed properly.
  3. On the user list view, select the resend-activation-email or reset-password action and verify that the content in the confirmation modal is displayed properly.
  4. Change the language selection & verify that the above steps are still valid.
  5. Select to log out of the application & verify that the content in the confirmation modal is displayed properly.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Code changes underneath the hood; no difference in user experience
Projects
None yet
Development

No branches or pull requests

2 participants