From d8a0e2941e54f13c9ab5924000f6d9cbaee8eac1 Mon Sep 17 00:00:00 2001 From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Date: Thu, 23 Jan 2020 11:01:40 -0500 Subject: [PATCH] Update PR template for TypeScript and added makefile command (#1039) --- Makefile | 2 ++ PULL_REQUEST_TEMPLATE.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c0e30c10c..221286214 100644 --- a/Makefile +++ b/Makefile @@ -28,6 +28,8 @@ pre-run: test: check-style npm test +check-types: | pre-run node_modules + npm run tsc install: node_modules diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index faa61c995..02390d85a 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -7,7 +7,7 @@ REMEMBER TO: - Run `make check-style` to check for style errors (required for all pull requests) - Run `make test` to ensure unit tests passed -- Run `make flow` to ensure type checking passed +- Run `make check-types` to ensure type checking passed - Add or update unit tests (required for all new features) - All new/modified APIs include changes to the [JavaScript driver](https://github.com/mattermost/mattermost-redux/blob/master/src/client/client4.js) -->