Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CronJob metadata labels #76

Closed
torchello opened this issue Aug 11, 2024 · 3 comments · Fixed by #77
Closed

CronJob metadata labels #76

torchello opened this issue Aug 11, 2024 · 3 comments · Fixed by #77

Comments

@torchello
Copy link
Contributor

Do I understand correctly that there is no way to add custom metadata labels to CronJob?
@DrPsychick
Copy link
Collaborator

You are right! That should not stay that way. Do you want to do an PR to add that feature?

@torchello
Copy link
Contributor Author

Sure – #77. Not sure how to test though. Please check.

@DrPsychick DrPsychick mentioned this issue Aug 14, 2024
Merged
@torchello
Copy link
Contributor Author

Seems like podAnnotations were never working as is: https://github.com/SickHub/charts/pull/78/files. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to attach custom pod labels torchello/charts
2 participants
@torchello @DrPsychick