Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building with json-schema #5

Open
neonstalwart opened this issue Dec 11, 2014 · 0 comments
Open

building with json-schema #5

neonstalwart opened this issue Dec 11, 2014 · 0 comments

Comments

@neonstalwart
Copy link

the build automatically discovers the json-schema package.json and sets the location for json-schema to be json-schema/lib based on the "directories" directive in the package.json. this causes the json-schema/lib/validate dependency to cause an error for the build since the build resolves that as json-schema/lib/lib/validate.

not sure what to do about this...

  1. use json-schema/validate as the dependency but configure the loader to set the location for the json-schema package to be json-schema/lib. this is not ideal since the default loader config won't work.
  2. change json-schema's package.json so that the build discovers json-schema/lib/validate as expected. this is not ideal since other node packages probably already rely on the "directories" directive.
  3. instruct people to include the following in their build profile - which is also not ideal since the default build profile config won't work.
{
    name: 'json-schema',
    location: 'json-schema',
    resourceTags: {
        amd: function (filename) {
            return /\/lib\/(?:links|validate)\.js$/.test(filename);
        }
    }
},

i guess this issue could probably belong in the json-schema repo but i'm reporting it here in the hope that adopters of dmodel will find this issue before complaining about how it isn't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant