Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False Positive StringToClassRule #23

Open
keywan-ghadami-oxid opened this issue Dec 27, 2019 · 1 comment
Open

False Positive StringToClassRule #23

keywan-ghadami-oxid opened this issue Dec 27, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@keywan-ghadami-oxid
Copy link

StringToClassRule reports fails positive for a string containing "Error" in my application.

Maybe this rule is not that important anymore because phpstan can report using string where class-string is expected.

A good compromise to reduce chance of fail positives would be to check only for full qualified class names in strings.
@Slamdunk
Copy link
Owner

Any PR is welcome 👍

@Slamdunk Slamdunk added the bug Something isn't working label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Slamdunk @keywan-ghadami-oxid