Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental_modifier round up when providing modifier_slots and round down when providing inventory_slots #5327

Open
QikaHome opened this issue Jan 26, 2025 · 1 comment
Labels
1.20 Issue affects 1.20 Enhancement Issue or pull request addresses a change to an existing functional feature Unreviewed Issue is new and is awaiting the team to review it

Comments

@QikaHome
Copy link

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.22

Mantle Version

1.11.36

Tinkers' Construct Version

3.9.1.19

Describe your issue

backpack_level_1.json:
{
"type": "tconstruct:incremental_modifier",
"allow_crystal": false,
"amount_per_item": 1,
"input": {
"tag": "forge:ingots/iron"
},
"level": 1,
"needed_per_level": 8,
"result": "tinkers_waste:backpack_upgrade",
"tools": { "item": "tinkers_waste:backpack" }
}
backpack_upgrade.json:
{
"level_display": "tconstruct:default",
"modules": [
{
"type": "tconstruct:inventory",
"slots": { "each_level": 18 }
},
{
"type": "tconstruct:modifier_slot",
"count": 1,
"name": "upgrades"
},
{
"type": "tconstruct:stat_boost",
"each_level": 2,
"operation": "multiply_base",
"stat": "tconstruct:tank_capacity"
},
{
"type": "tconstruct:inventory_menu",
"on_key": "any"
}
],
"tooltip_display": "always"
}
when I add any iron_ingots, it provide 1 upgrade slot;
but it doesnt provide any inventory slot until i add all 8 ingots

Crash Report

No response

Other mods

JEI,
TconJEI,
Json Things,
Ancient Debris Tweak,
Tinker's Things.
(All latest)

Tried reproducing with just Tinkers?

No

Performance Enchancers

None of the above

Searched for known issues?

I did not search

@QikaHome QikaHome added 1.20 Issue affects 1.20 Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Jan 26, 2025
@KnightMiner
Copy link
Member

Not every module is designed to work with incremental modifiers. There isn't a good way to divide things like slots. You are probably better off making a modifier with multiple levels than incremental here.

I can look into some support when you use higher counts for incremental, but it will always be round down.

@KnightMiner KnightMiner added Enhancement Issue or pull request addresses a change to an existing functional feature and removed Bug Issue describes unintended or broken behavior labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Issue affects 1.20 Enhancement Issue or pull request addresses a change to an existing functional feature Unreviewed Issue is new and is awaiting the team to review it
Projects
None yet
Development

No branches or pull requests

2 participants