Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaults should not be initialized by VRConfig #610

Open
ButterscotchV opened this issue Feb 26, 2023 · 0 comments · May be fixed by #617
Open

Defaults should not be initialized by VRConfig #610

ButterscotchV opened this issue Feb 26, 2023 · 0 comments · May be fixed by #617
Labels
Area: Server Related to the server Difficulty: Newbie Friendly Are you a new contributor looking for something to do? Try this :) Priority: Low Less important right now Type: Discussion Further information is requested

Comments

@ButterscotchV
Copy link
Member

SlimeVR-Server/server/src/main/java/dev/slimevr/config/VRConfig.java

Lines 53 to 80 in a0f3515

public VRConfig() {
// Initialize default settings for OSC Router
oscRouter.setPortIn(9002);
oscRouter.setPortOut(9000);
// Initialize default settings for VRC OSC
vrcOSC.setPortIn(9001);
vrcOSC.setPortOut(9000);
vrcOSC
.setOSCTrackerRole(
TrackerRole.WAIST,
vrcOSC.getOSCTrackerRole(TrackerRole.WAIST, true)
);
vrcOSC
.setOSCTrackerRole(
TrackerRole.LEFT_FOOT,
vrcOSC.getOSCTrackerRole(TrackerRole.WAIST, true)
);
vrcOSC
.setOSCTrackerRole(
TrackerRole.RIGHT_FOOT,
vrcOSC.getOSCTrackerRole(TrackerRole.WAIST, true)
);
// Initialize default settings for VMC
vmc.setPortIn(39540);
vmc.setPortOut(39539);
}

These defaults should be set by the classes themselves, it feels really wrong to be doing it by VRConfig.
@ButterscotchV ButterscotchV added Difficulty: Newbie Friendly Are you a new contributor looking for something to do? Try this :) Type: Discussion Further information is requested Priority: Low Less important right now Area: Server Related to the server labels Feb 26, 2023
@marcozzxx810 marcozzxx810 linked a pull request Mar 1, 2023 that will close this issue
Open
@ImUrX ImUrX linked a pull request Mar 2, 2023 that will close this issue
fix: move default config to class #617
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Server Related to the server Difficulty: Newbie Friendly Are you a new contributor looking for something to do? Try this :) Priority: Low Less important right now Type: Discussion Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move default config to class marcozzxx810/SlimeVR-Server
1 participant
@ButterscotchV