Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double input with fcitx5 on chrome dev under some cases #1604

Open
CnTeng opened this issue Dec 11, 2024 · 2 comments · May be fixed by #1648
Open

Double input with fcitx5 on chrome dev under some cases #1604

CnTeng opened this issue Dec 11, 2024 · 2 comments · May be fixed by #1648

Comments

@CnTeng
Copy link

CnTeng commented Dec 11, 2024

This was happend for me in niri and cosmic.

Chrome which utilizes text-input-v3 has the issue of letters get doubly input for certain input boxes, even when no ime is in use (but no issues when the process of fcitx5 is being killed).

Related issue: YaLTeR/niri#620 (comment)
https://issues.chromium.org/issues/40113488#comment127
@merrkry
Copy link

merrkry commented Dec 11, 2024

I can reproduce this, and here's a tldr:

When having multiple chromium / electron (e.g. multiples windows from the same electron application) window running, every character typed will be repeated in current input focus field, as many times as the number of chromium/electron instance.

These chromium flags are used:

--enable-wayland-ime --wayland-text-input-version=3

@hayandev hayandev mentioned this issue Jan 22, 2025
Merged
@hayandev
Copy link
Contributor

Although it doesn’t fully adhere to the text input v3 specification, it appears to work reasonably well with minimal code changes.
The addition of a pending status required by the protocol specification is mentioned in another existing issue(#1614), so presumably whoever is looking at that issue will address it separately.

kchibisov added a commit to kchibisov/smithay that referenced this issue Jan 24, 2025
@kchibisov
text-input: fix active instance tracking
964cce6 
Only one text-input must be enabled at a time, by checking the
text-input id when issuing a request and comparing to the active one,
however the regular `Enabled` events must be send for all of them,
and as for the leave, we also send it for all the events to make it
symmetrical with the `enter.

Fixes: 475072d (text-input: Ensure only one enabled...)
Fixes Smithay#1604.
@kchibisov kchibisov linked a pull request Jan 24, 2025 that will close this issue
Open
kchibisov added a commit to kchibisov/smithay that referenced this issue Jan 24, 2025
@kchibisov
text-input: fix active instance tracking
32acb7e 
Only one text-input must be enabled at a time, by checking the
text-input id when issuing a request and comparing to the active one,
however the regular `Enabled` events must be send for all of them,
and as for the leave, we also send it for all the events to make it
symmetrical with the `enter.

Fixes: 475072d (text-input: Ensure only one enabled...)
Fixes Smithay#1604.
kchibisov added a commit to kchibisov/smithay that referenced this issue Jan 24, 2025
@kchibisov
text-input: fix active instance tracking
eb40c35 
Only one text-input must be enabled at a time, by checking the
text-input id when issuing a request and comparing to the active one,
however the regular `Enabled` events must be send for all of them,
and as for the leave, we also send it for all the events to make it
symmetrical with the `enter.

Fixes: 475072d (text-input: Ensure only one enabled...)
Fixes Smithay#1604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

text-input: fix active instance tracking kchibisov/smithay
3 participants
@hayandev @CnTeng @merrkry