text-input: fix active instance tracking #1648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
force-pushed
the
fix-broken-ime
branch
from
964cce6 to
32acb7e
Compare
|
Could you test this @hayandev with chrome? |
Only one text-input must be enabled at a time, by checking the text-input id when issuing a request and comparing to the active one, however the regular `Enabled` events must be send for all of them, and as for the leave, we also send it for all the events to make it symmetrical with the `enter. Fixes: 475072d (text-input: Ensure only one enabled...) Fixes Smithay#1604.
kchibisov
force-pushed
the
fix-broken-ime
branch
from
32acb7e to
eb40c35
Compare
It works great! |
PolyMeilex
added
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one text-input must be enabled at a time, by checking the text-input id when issuing a request and comparing to the active one, however the regular
Enabledevents must be send for all of them, and as for the leave, we also send it for all the events to make it symmetrical with the `enter.Fixes: 475072d (text-input: Ensure only one enabled...)
Fixes #1604.
--
Should be backported to patch release, otherwise text-input doesn't work at all.