Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve/add pill builder for customization #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sherlockvn
Copy link

@sherlockvn sherlockvn commented Jul 3, 2023

Hello @Sorunome, I would like to make a change to your package because the current Pill widget uses FutureBuilder, which causes the message to be rebuilt multiple times and results in a blink effect. My solution is to cache the PillInfo outside of the widget and avoid using FutureBuilder internally. Additionally, I believe that the current customization options for the Pill widget are quite limited.

  • Before PillBuilder:
Screen.Recording.2023-07-03.at.14.16.03.mov
  • After have PillBuilder:
Screen.Recording.2023-07-03.at.14.16.47.mov

@sherlockvn sherlockvn force-pushed the improve/add-customize-pill-builder branch 2 times, most recently from ba3a3cc to 831af80 Compare July 3, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant