Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Conformance check for scs-0211-v1 (and v2) is broken #662

Open
martinmo opened this issue Jul 18, 2024 · 8 comments · May be fixed by #745
Open

[BUG] Conformance check for scs-0211-v1 (and v2) is broken #662

martinmo opened this issue Jul 18, 2024 · 8 comments · May be fixed by #745
Assignees
Labels
bug Something isn't working Container Issues or pull requests relevant for Team 2: Container Infra and Tooling good first issue Good for newcomers SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Milestone

Comments

@martinmo
Copy link
Member

@martinmo martinmo added the bug Something isn't working label Jul 18, 2024
@martinmo martinmo self-assigned this Jul 18, 2024
@martinmo martinmo added Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels Jul 18, 2024
@martinmo martinmo changed the title [BUG] Conformance check for scs-0211-v1 is not aligned with standard (too strict) [BUG] Conformance check for scs-0211-v1 (and v2) is broken Jul 19, 2024
@martinmo
Copy link
Member Author

I reviewed and tested the script, unfortunately it appears to be broken in more ways, therefore I broadened the scope of this issue:

  • it uses packages not specified in requirements.txt
  • it doesn't yet check what CSI provider is used, to make an informed decision if the storage is local/ephemeral or not (e.g., using a simple local-path provisionar like kind sets up already satisfies the script)
  • it requires some sonobuoy result file which isn't mentioned anywhere else

@martinmo martinmo added this to the R7 (v8.0.0) milestone Aug 7, 2024
@mbuechse mbuechse added the good first issue Good for newcomers label Aug 26, 2024
@fraugabel
Copy link
Contributor

after recompiling requirements and deleting gen_sonobuoy function and function calls i could successfully test my kind cluster with the default "storageClassName":"standard" . I will now try to provoke errors to see, if it still needs debugging

@anjastrunk anjastrunk mentioned this issue Sep 4, 2024
29 tasks
@martinmo martinmo removed their assignment Sep 5, 2024
@fraugabel
Copy link
Contributor

There are problems as soon as errors occur. In the event of an error, the test-pvc is not removed, which leads to errors when the test is repeated. So i will have a look into the clean-up-part

@fraugabel
Copy link
Contributor

I am back on this issue and wonder, whether i should dig deeper into that problem, meaning (write a cleanup bypass part for cleaning up, when errors occur) or port it to sonobuoy right a way?

@mbuechse
Copy link
Contributor

mbuechse commented Oct 7, 2024

I'm afraid I can't tell what's happening here. Does this have a (non-) associated PR that I could look at?

@fraugabel
Copy link
Contributor

@mbuechse right now there is no PR but a branch you can look at. What i am currently working on (from tomorrow on) is the error handling (the exceptions need to be in the right block to get a usable log)
https://github.com/SovereignCloudStack/standards/tree/issue/662_default_storage_class

@mbuechse
Copy link
Contributor

It would be great to have a PR. You can open it as draft.

@mbuechse
Copy link
Contributor

What is happening here? Of course, there is a PR, and has been since Sep 9?!
#745

@mbuechse mbuechse linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Container Issues or pull requests relevant for Team 2: Container Infra and Tooling good first issue Good for newcomers SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants