[Bug]: No error or exception thrown for limit reached

[quantumwebco]

Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?

• Yes, it's still reproducable

What version of Laravel Excel are you using?

3.1

What version of Laravel are you using?

9.38

What version of PHP are you using?

8.1

Describe your issue

When defining a limit with the WithLimit concern there is no error or exception thrown. I would like to catch the exception with the number of rows that were imported or failed, or the row number it finished at

I have also tried manually adding a $limit property and throwing an exception in the model() method when it's reached but even with SkipsOnError, SkipsOnFailure and SkipsFailures, SkipsErrors it still rolls back the current import

I did kind of work out a workaround by adding the index to the row in prepareForValidation() and then adding a max validation rule of the limit to the index property but it's kinda janky

How can the issue be reproduced?

Throw an exception in the model() method or add a limit with the WithLimit concern

What should be the expected behaviour?

When the limit via the concern WithLimit is reached throw an exception that can be caught and an error message returned to the user or add rows after the limit is reached to the failures array to show with $import->failures()

Throwing an exception from the model() method could push that row to the errors collection so it can be got with $import->errors() after importing. If batch importing can all rows up to that exception still be imported? As per SkipsErrors/Failures, rather than just rolling back

[patrickbrouwers]

Moved to discussions as this is a proposal not a bug.

I would be open for a PR that adds a method onLimitReached method that will be called when limit is reached. Adding an exception would be a breaking change and is also not really how this concern is intended to be used.