Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting DOM focus via the wiki testable statements #13

Open
joanmarie opened this issue Apr 21, 2017 · 9 comments
Open

Comments

@joanmarie
Copy link
Collaborator

We have several tests (e.g. aria-activedescendant) which require setting DOM focus on an element. And I can add this manually to an already generated test as a step, e.g.:

      {
         "type" : "event",
         "element" : "test",
         "event" : "focus",
         "title": "Put focus on test element"
      },

Is this the desired way to do DOM focus? If not, what is? But if so.... Looking at make_tests.pl:

      } elsif ($type eq "event") {
        print STDERR "Event support from wikis is not yet implemnted at line #lineCounter\n";

Since we are currently doing wiki-based testable statements, it would be great to solve this problem so the aria-activedescendant tests don't have to be run manually.

halindrome pushed a commit that referenced this issue May 9, 2017
Update format of "Create Session" command
@joanmarie
Copy link
Collaborator Author

@joanmarie
Copy link
Collaborator Author

Syntax in spec for event: https://spec-ops.github.io/atta-api/index.html#event

@joanmarie
Copy link
Collaborator Author

Tests in the wiki using the syntax (sans description, but...), start here: https://www.w3.org/wiki/ARIA_1.1_Testable_Statements#application_activedescendant

@joanmarie
Copy link
Collaborator Author

Sample output when using make_tests.pl to generate tests from wiki:

Event support from wikis is not yet implemnted at line #lineCounter
Event support from wikis is not yet implemnted at line #lineCounter
Event support from wikis is not yet implemnted at line #lineCounter
Event support from wikis is not yet implemnted at line #lineCounter

@halindrome
Copy link
Member

We need a wiki syntax for the event... which I thought we had specified.

@joanmarie
Copy link
Collaborator Author

Isn't the syntax we specified what I commented above?

@halindrome
Copy link
Member

No. That's the JSON structure.

@halindrome
Copy link
Member

Question: do you think that the JSON you are putting in the activedescendant tests actually works? ATTAcomm has support for it - it calls focus. But my understanding was that focus was not portable and didn't necessarily emulate a user setting focus reliably.

halindrome added a commit that referenced this issue Jun 9, 2017
An event record in the wiki will generate corresponding
JSON in the test now.  References #13
@joanmarie
Copy link
Collaborator Author

It doesn't cause an accessible focus event to be emitted, but if I remove that step from the json, I get new failures, namely that the element lacks STATE_FOCUSED.

halindrome added a commit that referenced this issue Jun 22, 2017
An event record in the wiki will generate corresponding
JSON in the test now.  References #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants