From 985c0a25971b182751519ef04ffdccace8eb1326 Mon Sep 17 00:00:00 2001 From: "liviu.ungureanu" Date: Mon, 10 Feb 2020 20:54:48 +0000 Subject: [PATCH] added bodyEither directive --- .../com/spingo/op_rabbit/Directives.scala | 22 ++++++++++++++++++ .../com/spingo/op_rabbit/EnhancedTry.scala | 10 ++++++++ .../com/spingo/op_rabbit/DirectivesSpec.scala | 23 +++++++++++++++++++ 3 files changed, 55 insertions(+) create mode 100644 core/src/main/scala/com/spingo/op_rabbit/EnhancedTry.scala diff --git a/core/src/main/scala/com/spingo/op_rabbit/Directives.scala b/core/src/main/scala/com/spingo/op_rabbit/Directives.scala index 960bfb3..c52e4a2 100644 --- a/core/src/main/scala/com/spingo/op_rabbit/Directives.scala +++ b/core/src/main/scala/com/spingo/op_rabbit/Directives.scala @@ -7,6 +7,7 @@ import scala.language.implicitConversions import shapeless._ import com.spingo.op_rabbit.Binding._ import com.spingo.op_rabbit.Exchange.ExchangeType +import EnhancedTry._ import scala.util.{Failure, Success, Try} @@ -179,6 +180,27 @@ trait Directives { } } + /** + Extract the message body as a Either. Uses a [[com.spingo.op_rabbit.RabbitUnmarshaller RabbitUnmarshaller]] to deserialize. + In case the body cannot be unmarshalled, the exception is present in the Left of the Either. + In this way the client code can have the unmarshalling error reason. + Example: + + {{{ + bodyOpt(as[JobDescription]) { jobDescriptionEither => ... + } + }}} + */ + def bodyEither[T](um: RabbitUnmarshaller[T]): Directive1[Either[Throwable, T]] = new Directive1[Either[Throwable, T]] { + def happly(fn: ::[Either[Throwable, T], HNil] => Handler): Handler = { (promise, delivery) => + val dataTry = Try { + um.unmarshall(delivery.body, Option(delivery.properties.getContentType), Option(delivery.properties.getContentEncoding)) + } + + fn(dataTry.toEither :: HNil)(promise, delivery) + } + } + /** Extract any arbitrary value from the delivery / Java RabbitMQ objects. Accepts a function which receives a Delivery and returns some value. */ diff --git a/core/src/main/scala/com/spingo/op_rabbit/EnhancedTry.scala b/core/src/main/scala/com/spingo/op_rabbit/EnhancedTry.scala new file mode 100644 index 0000000..03aa2f1 --- /dev/null +++ b/core/src/main/scala/com/spingo/op_rabbit/EnhancedTry.scala @@ -0,0 +1,10 @@ +package com.spingo.op_rabbit + +import scala.util.{Success, Try} + +object EnhancedTry { + implicit class EnhancedTryImpl[T](t: Try[T]) { + def toEither: Either[Throwable, T] = + t.transform(success => Success(Right(success)), exception => Success(Left(exception))).get + } +} diff --git a/core/src/test/scala/com/spingo/op_rabbit/DirectivesSpec.scala b/core/src/test/scala/com/spingo/op_rabbit/DirectivesSpec.scala index e46cd8e..0892078 100644 --- a/core/src/test/scala/com/spingo/op_rabbit/DirectivesSpec.scala +++ b/core/src/test/scala/com/spingo/op_rabbit/DirectivesSpec.scala @@ -107,6 +107,29 @@ class DirectivesSpec extends FunSpec with Matchers with Inside { } } should be (acked) } + + it("yields the value for both directives when one is bodyEither") { + val delivery = testDelivery(body = "hi".getBytes, properties = Seq(ReplyTo("place"))) + resultFor(delivery) { + (bodyEither(as[String]) & property(ReplyTo)) { (bodyEither, replyTo) => + replyTo should be ("place") + bodyEither.right.get should be ("hi") + ack + } + } should be (acked) + } + } + + describe("bodyEither") { + it("yields the value as an option") { + val delivery = testDelivery(body = "hi".getBytes) + resultFor(delivery) { + (bodyEither(as[String])) { (bodyEither) => + bodyEither.right.get should be ("hi") + ack + } + } should be (acked) + } } describe("|") {