Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm: warnings when compiling with cuda 12.8 #1827

Open
eddy16112 opened this issue Jan 30, 2025 · 1 comment
Open

Realm: warnings when compiling with cuda 12.8 #1827

eddy16112 opened this issue Jan 30, 2025 · 1 comment
Labels
bug Realm Issues pertaining to Realm

Comments

@eddy16112
Copy link
Contributor

We have seen many warnings when compiling Realm with CUDA 12.8, e.g.

In file included from /home/scratch.weiwu_sw/anaconda3/envs/cuda128/x86_64-conda-linux-gnu/sysroot/usr/include/limits.h:26,
                 from /home/scratch.weiwu_sw/anaconda3/envs/cuda128/lib/gcc/x86_64-conda-linux-gnu/11.2.0/include-fixed/limits.h:203,
                 from /home/scratch.weiwu_sw/anaconda3/envs/cuda128/lib/gcc/x86_64-conda-linux-gnu/11.2.0/include-fixed/syslimits.h:7,
                 from /home/scratch.weiwu_sw/anaconda3/envs/cuda128/lib/gcc/x86_64-conda-linux-gnu/11.2.0/include-fixed/limits.h:34,
                 from /home/weiwu/scratch/legion-master/runtime/realm/profiling.h:21,
                 from /home/weiwu/scratch/legion-master/runtime/realm/profiling.cc:18:
/home/scratch.weiwu_sw/anaconda3/envs/cuda128/x86_64-conda-linux-gnu/sysroot/usr/include/features.h:330:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
  330 | #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)

/home/weiwu/scratch/legion-master/runtime/realm/activemsg.inl:382:10: warning: unused variable 'ok' [-Wunused-variable]
  382 |     bool ok = fbs.append_bytes(data, datalen);

These warnings come from the following pattern

bool ok = foo();
assert(ok);

The assert will be optimized in release mode, not sure why it is not triggered before.
I create this ticket to remind myself to fix it later.

@eddy16112 eddy16112 added bug Realm Issues pertaining to Realm labels Jan 30, 2025
@muraj
Copy link

muraj commented Jan 30, 2025

Check if NDEBUG is being defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Realm Issues pertaining to Realm
Projects
None yet
Development

No branches or pull requests

2 participants