Attempt to call global 'FCF_DockUpdate' (a nil value)

[seblindfors]

Classic only bug, probably related to modularizing code to action bar and chat addons, which invokes a call from the pet action bar to UIParent_ManageFramePositions which then tries to call FCF_DockUpdate. Looking at the loading order, this happens before the chat addon has loaded.

Time: Thu Nov 28 15:44:45 2024
Count: 1
Stack: ...PanelManager/Classic/UIParentPanelManager_Shared.lua:1035: attempt to call global 'FCF_DockUpdate' (a nil value)
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:1035: in function `UIParentManageFramePositions'
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:325: in function <...PanelManager/Classic/UIParentPanelManager_Shared.lua:312>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:1045: in function `UIParent_ManageFramePositions'
[string "@Interface/AddOns/Blizzard_ActionBar/Classic/PetActionBarFrame.lua"]:37: in function <...Ons/Blizzard_ActionBar/Classic/PetActionBarFrame.lua:36>
[string "=[C]"]: in function `Show'
[string "@Interface/AddOns/Blizzard_ActionBar/Classic/PetActionBarFrame.lua"]:279: in function `ShowPetActionBar'
[string "@Interface/AddOns/Blizzard_ActionBar/Classic/PetActionBarFrame.lua"]:74: in function <...Ons/Blizzard_ActionBar/Classic/PetActionBarFrame.lua:55>

Locals: self = Frame {
}
yOffsetFrames = <table> {
 1 = "pet"
}
xOffsetFrames = <table> {
}
hasBottomLeft = nil
hasBottomRight = nil
hasPetBar = 1
anchorY = 0
buffsAnchorY = 0
rightActionBars = 0
numBossFrames = 0
(*temporary) = nil
(*temporary) = "attempt to call global 'FCF_DockUpdate' (a nil value)"
UIPARENT_VARIABLE_OFFSETS = <table> {
 rightActionBarsX = 141.000031
}

Fix probably:

diff --git a/Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua b/Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua
index dab7ebb78..a232ca0b4 100644
--- a/Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua
+++ b/Interface/AddOns/Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua
@@ -1032,7 +1032,9 @@ function FramePositionDelegate:UIParentManageFramePositions()
 	anchorY = FramePositionDelegate_Override_QuestWatchFrameOffsets(anchorY, rightActionBars, buffsAnchorY);
 
 	-- Update chat dock since the dock could have moved
-	FCF_DockUpdate();
+	if FCF_DockUpdate then
+		FCF_DockUpdate();
+	end
 
 	if UpdateContainerFrameAnchors then
 		UpdateContainerFrameAnchors();