[Enhancement] adjust translate function syntax structure to prevent parser performance rollback (backport #54830) #55514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
parser performance rollback is introduced by this patch #54185
parser performance will rollback when there are many function call in query.
the parser of this case will take about 100ms.
bad case:
![image](https://private-user-images.githubusercontent.com/91597003/400993541-6c442075-f90c-435e-b669-2bab50c3a659.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjQ5MzcsIm5iZiI6MTczODk2NDYzNywicGF0aCI6Ii85MTU5NzAwMy80MDA5OTM1NDEtNmM0NDIwNzUtZjkwYy00MzVlLWI2NjktMmJhYjUwYzNhNjU5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIxNDM1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc5MGM1MDk5YjU5ZGFiNjc3M2Q2MWU2M2FmMzYyODJkZDFkYzgyZTBkYmMzOGVjZTEwNzhlZjdmNTEwZjkyNjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.aO_X5QqRLyrod2fwTd8VJSPNzSTvwm4lk6deNJPcCvA)
normal case:
![image](https://private-user-images.githubusercontent.com/91597003/400993333-85c83cec-e468-42a6-9875-0bcde413328c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjQ5MzcsIm5iZiI6MTczODk2NDYzNywicGF0aCI6Ii85MTU5NzAwMy80MDA5OTMzMzMtODVjODNjZWMtZTQ2OC00MmE2LTk4NzUtMGJjZGU0MTMzMjhjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIxNDM1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZkZmMyN2FlMjRmN2VjMzkwYjk0YjhjMGEzZWY5NGU3YWJhNjFhNDg4Mzc4ODhkNjUwNjA3NmVkODA0YzE3YTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FYC_XcrYdyk9PkSI8tpyCGCmqse4b1ymgF0WLV7aatg)
What I'm doing:
Translate statement conflicts with translate function, so stripping translate function from simple function prevents performance rollback.
adjust translate function syntax structure and remove
getCharPositionInLine
fortranslate
to prevent parser performance rollback.base: 100ms
optimized: 4ms
Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/8932#issuecomment-2572967332
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: