fix(watch-mode): allow run plugin in watch mode #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love to get this merged. @IvanRodriCalleja did this work for your local env? got a sandbox project setup for testing that I can tryout? I tried in my own with |
|
I had it working in my local with this changes but finally i migrated to |
|
@IvanRodriCalleja good idea, I will do that to :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6
The problem with the watch mode was that the input for content script was not regenerated and the new manifest was wrong generated because the content script was not found in the bundle as a file.
@StarkShang Would you be open to review and release a new version in case you are agree with the fix or do you prefer that i fork the repo and maintain my own plugin?