From 635d9f671e753885f13b1462304eed5334cb907c Mon Sep 17 00:00:00 2001 From: Shadowy Super Coder Date: Tue, 15 Oct 2024 15:40:04 -0600 Subject: [PATCH] Updates for reviewer feedback --- core/startos/src/auth.rs | 2 +- core/startos/src/db/mod.rs | 4 ++-- core/startos/src/lib.rs | 10 ++++++---- core/startos/src/registry/db.rs | 9 +++++++-- 4 files changed, 16 insertions(+), 9 deletions(-) diff --git a/core/startos/src/auth.rs b/core/startos/src/auth.rs index c4c75a141..a6b624b70 100644 --- a/core/startos/src/auth.rs +++ b/core/startos/src/auth.rs @@ -107,7 +107,7 @@ pub fn auth() -> ParentHandler { ) .subcommand( "session", - session::().with_about("List or Kill StartOS sessions"), + session::().with_about("List or kill StartOS sessions"), ) .subcommand( "reset-password", diff --git a/core/startos/src/db/mod.rs b/core/startos/src/db/mod.rs index c15ef60d3..1ed7e9ab9 100644 --- a/core/startos/src/db/mod.rs +++ b/core/startos/src/db/mod.rs @@ -35,7 +35,7 @@ pub fn db() -> ParentHandler { "dump", from_fn_async(cli_dump) .with_display_serializable() - .with_about("Return db tables and records"), + .with_about("Filter/query db to display tables and records"), ) .subcommand("dump", from_fn_async(dump).no_cli()) .subcommand( @@ -312,7 +312,7 @@ pub fn put() -> ParentHandler { "ui", from_fn_async(ui) .with_display_serializable() - .with_about("Store pointer and value in db") + .with_about("Add path and value to db") .with_call_remote::(), ) } diff --git a/core/startos/src/lib.rs b/core/startos/src/lib.rs index 1620c044e..754362bc9 100644 --- a/core/startos/src/lib.rs +++ b/core/startos/src/lib.rs @@ -149,7 +149,7 @@ pub fn main_api() -> ParentHandler { .subcommand( "auth", auth::auth::().with_about( - "Commands related to Authentication such as logging in, resetting password, etc", + "Commands related to Authentication i.e. login, logout, reset-password", ), ) .subcommand( @@ -158,11 +158,13 @@ pub fn main_api() -> ParentHandler { ) .subcommand( "ssh", - ssh::ssh::().with_about("Add, delete, or list ssh keys"), + ssh::ssh::() + .with_about("Commands for interacting with ssh keys i.e. add, delete, list"), ) .subcommand( "wifi", - net::wifi::wifi::().with_about("Commands related to wifi networks"), + net::wifi::wifi::() + .with_about("Commands related to wifi networks i.e. add, connect, delete"), ) .subcommand( "disk", @@ -447,7 +449,7 @@ pub fn diagnostic_api() -> ParentHandler { .subcommand( "diagnostic", diagnostic::diagnostic::() - .with_about("Commands to display logs, restart the server, etc"), + .with_about("Diagnostic commands i.e. logs, restart, rebuild"), ) } diff --git a/core/startos/src/registry/db.rs b/core/startos/src/registry/db.rs index 147fa7b67..8de9f8743 100644 --- a/core/startos/src/registry/db.rs +++ b/core/startos/src/registry/db.rs @@ -22,7 +22,7 @@ pub fn db_api() -> ParentHandler { "dump", from_fn_async(cli_dump) .with_display_serializable() - .with_about("Return db tables and records"), + .with_about("Filter/query db to display tables and records"), ) .subcommand( "dump", @@ -30,7 +30,12 @@ pub fn db_api() -> ParentHandler { .with_metadata("admin", Value::Bool(true)) .no_cli(), ) - .subcommand("apply", from_fn_async(cli_apply).no_display().with_about("Update a db record")) + .subcommand( + "apply", + from_fn_async(cli_apply) + .no_display() + .with_about("Update a db record"), + ) .subcommand( "apply", from_fn_async(apply)