Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter names in BaseErrorListener #83

Open
hakanai opened this issue Oct 18, 2022 · 0 comments
Open

Improve parameter names in BaseErrorListener #83

hakanai opened this issue Oct 18, 2022 · 0 comments

Comments

@hakanai
Copy link

hakanai commented Oct 18, 2022

BaseErrorListener contains some parameter names which are presumably taken directly from the original Java version.

The one which grates on me the most is msg: String in syntaxError - I had renamed this to message in my subclass, but with Kotlin, you get a compiler warning if the names don't match precisely. So really any parameter names in the base class should be un-abbreviated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant