Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect on how we handle the installation of dependemcies #78

Open
martin-azpillaga opened this issue Jul 1, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@martin-azpillaga
Copy link
Collaborator

The way we handle the installation of dependencies is very rigid and can lead to version mismatches.

Following the project's "configurable magic" philosophy, we could install the dependencies "magically" by default, but if the user specifies a version for one of these dependencies we should respect that version and not install anything.

Here is the current solution:

project.dependencies.add("implementation", "com.strumenta.kolasu:language-server:${BuildConfig.KOLASU_LSP_VERSION}")
project.dependencies.add("implementation", "com.strumenta.kolasu:kolasu-core:${BuildConfig.KOLASU_VERSION}")
project.dependencies.add("implementation", "org.eclipse.lsp4j:org.eclipse.lsp4j:${BuildConfig.LSP4J_VERSION}")
project.dependencies.add("implementation", "org.apache.lucene:lucene-core:${BuildConfig.LUCENE_VERSION}")
project.dependencies.add("implementation", "org.apache.lucene:lucene-codecs:${BuildConfig.LUCENE_VERSION}")
project.dependencies.add("implementation", "org.apache.lucene:lucene-queryparser:${BuildConfig.LUCENE_VERSION}")
project.dependencies.add("testImplementation", "com.strumenta.kolasu:language-server-testing:${BuildConfig.KOLASU_LSP_VERSION}")
project.dependencies.add("testImplementation", "org.junit.jupiter:junit-jupiter:${BuildConfig.JUNIT_VERSION}")

@martin-azpillaga martin-azpillaga added the enhancement New feature or request label Jul 1, 2024
@martin-azpillaga
Copy link
Collaborator Author

@loradd I remember you had another approach for this in mind. Could you share it here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant