New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parse issue reporting #59

Open

alessiostalla opened this issue Jan 30, 2024 · 0 comments · May be fixed by #74

Member

alessiostalla commented Jan 30, 2024

See the work done on Kolasu Strumenta/kolasu#292

Mochitto added a commit to Mochitto/tylasu that referenced this issue


          Improve parsing Issues reporting

e6dd826

Solves Strumenta#59
Inspired by [Strumenta/kolasu#292](Strumenta/kolasu#292).

- `Issue`'s messages are now capitalized to improve readability.
- `Position`'s `isEmpty` method has been safely renamed to `isFlat` to
  match the [convention used in kolasu](https://github.com/Strumenta/kolasu/blob/0676131e403718d2d99c792dc0a81a87bd48a34f/ast/src/commonMain/kotlin/com/strumenta/kolasu/model/Point.kt#L136).
  This ensures consistency across the StarLasu collection.
  The `isEmpty` method has now been deprecated and is to be removed in
  the future.
- Parsing `Issue`s report the correct `Position` by taking into
  consideration the length of the token, to improve UX.

Mochitto added a commit to Mochitto/tylasu that referenced this issue


          Improve parsing Issues reporting

39904e3

Resolve Strumenta#59
Inspired by [Strumenta/kolasu#292](Strumenta/kolasu#292).

- `Issue`'s messages are now capitalized to improve readability.
- `Position`'s `isEmpty` method has been safely renamed to `isFlat` to
  match the [convention used in kolasu](https://github.com/Strumenta/kolasu/blob/0676131e403718d2d99c792dc0a81a87bd48a34f/ast/src/commonMain/kotlin/com/strumenta/kolasu/model/Point.kt#L136).
  This ensures consistency across the StarLasu collection.
  The `isEmpty` method has now been deprecated and is to be removed in
  the future.
- Parsing `Issue`s report the correct `Position` by taking into
  consideration the length of the token, to improve UX.

Mochitto added a commit to Mochitto/tylasu that referenced this issue


          Improve parsing Issues reporting

878ee1a

Resolve Strumenta#59
Inspired by [Strumenta/kolasu#292](Strumenta/kolasu#292).

- `Issue`'s messages are now capitalized to improve readability.
- `Position`'s `isEmpty` method has been safely renamed to `isFlat` to
  match the [convention used in kolasu](https://github.com/Strumenta/kolasu/blob/0676131e403718d2d99c792dc0a81a87bd48a34f/ast/src/commonMain/kotlin/com/strumenta/kolasu/model/Point.kt#L136).
  This ensures consistency across the StarLasu collection.
  The `isEmpty` method has now been deprecated and is to be removed in
  the future.
- Parsing `Issue`s report the correct `Position` by taking into
  consideration the length of the token, to improve UX.

Mochitto linked a pull request

that will close this issue

Improve parsing Issues reporting #74

Open

Mochitto added a commit to Mochitto/tylasu that referenced this issue


          Improve parsing Issues reporting

57f2b15

Resolve Strumenta#59
Inspired by [Strumenta/kolasu#292](Strumenta/kolasu#292).

- `Issue`'s messages are now capitalized to improve readability.
- `Position`'s `isEmpty` method has been safely renamed to `isFlat` to
  match the [convention used in kolasu](https://github.com/Strumenta/kolasu/blob/0676131e403718d2d99c792dc0a81a87bd48a34f/ast/src/commonMain/kotlin/com/strumenta/kolasu/model/Point.kt#L136).
  This ensures consistency across the StarLasu collection.
  The `isEmpty` method has now been deprecated and is to be removed in
  the future.
- Parsing `Issue`s report the correct `Position` by taking into
  consideration the length of the token, to improve UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment