Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calendar details when modified by external app #47

Open
jgriffiths opened this issue Jun 1, 2016 · 1 comment
Open

Update calendar details when modified by external app #47

jgriffiths opened this issue Jun 1, 2016 · 1 comment
Assignees
@jgriffiths
Labels
enhancement Genuinly new functionality.

Comments

@jgriffiths
Copy link
Contributor

This is instead of a refresh button as suggested by @Gitoffthelawn. Also noticed by @mzagol during offline testing of another issue.

There are two parts here, 1) reload the calendar details when the app is resumed, and 2) Register for updates from the O/S when any calendars change while running.

Note that the count may still be wrong until a workaround for issue #44 is found.
@jgriffiths jgriffiths mentioned this issue Jun 1, 2016
Open
@jgriffiths jgriffiths added the enhancement Genuinly new functionality. label Jun 1, 2016
@jgriffiths jgriffiths self-assigned this Jun 1, 2016
@Gitoffthelawn
Copy link

I agree. I proposed a refresh button simply because it would be less work to implement. But if you make it automatic, all the better!

jgriffiths added a commit that referenced this issue Jun 1, 2016
@jgriffiths
Initial support for reloading the calendar on app resume
6949507 
Part 1 of issue #47. Per the FIXMEs this needs to be smarter about
avoiding updates where possible and part 2 still needs implementing.
jgriffiths added a commit that referenced this issue Jun 2, 2016
@jgriffiths
Listen and respond to broadcast calendar changes
5eb6f48 
Part 1 of issue #47. The code to (re)initialise the calendar info is now
called from app init, activity resume and broadcast receive so needs to be
made safe and efficient for all three cases.
jgriffiths added a commit that referenced this issue Jun 2, 2016
@jgriffiths
Log the received action, not our filters (which we know)
552237a 
For issue #47.
jgriffiths added a commit that referenced this issue Jun 3, 2016
@jgriffiths
Avoid updating our calendar info if nothing has changed
a5bfa2b 
For issue #47. In the typical case of no changes when resuming this
makes the behaviour the same as previous versions. If there any issues
around changing the calendar list they should now only occur after the
calendar is actually changed.
jgriffiths added a commit that referenced this issue Jun 3, 2016
@jgriffiths
Update the changelog for issue #47 changes
4f5f8fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgriffiths jgriffiths

Labels
enhancement Genuinly new functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgriffiths @Gitoffthelawn