Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass node.message string by reference #3

Open
SunitRaut opened this issue Jan 6, 2021 · 1 comment
Open

Pass node.message string by reference #3

SunitRaut opened this issue Jan 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@SunitRaut
Copy link
Owner

Instead of moving node.message to char sendbuffer[], pass node.message by reference to send() and sendWithRetry() to save space consumed by sendbuffer[].
61 bytes can be saved.

At the same time, we need to take care because in networkMode, if sendbuffer[] is eliminated, node.message will be modified and user won't be aware of this, leading to unexpected behaviour for the user.

@SunitRaut SunitRaut added the enhancement New feature or request label Jan 6, 2021
@SunitRaut
Copy link
Owner Author

This enhancement could save 61 bytes of RAM, but needs detailed analysis before making this switch to ensure no unexpected behaviour takes place at user's end due to this change.

This issue will be dealt with in next tag / release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant