Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasional segfaults when dipole-dipole interactions are enabled #65

Closed
kbarros opened this issue Feb 27, 2023 · 1 comment · Fixed by #66
Closed

Occasional segfaults when dipole-dipole interactions are enabled #65

kbarros opened this issue Feb 27, 2023 · 1 comment · Fixed by #66

Comments

@kbarros
Copy link
Member

kbarros commented Feb 27, 2023

See discussion here: JuliaLang/julia#48722

As a temporary workaround, we have disabled dipole-dipole interactions in unit tests that check for energy consistency. 3d54b13
@kbarros kbarros mentioned this issue Feb 27, 2023
Merged
@kbarros
Copy link
Member Author

kbarros commented Mar 1, 2023 •
edited
Loading

The underlying problem was that deepcopy is frequently memory unsafe, per Julia developers (this needs to be announced more broadly). Attempting to deecopy an FFTW plan was leading to a use-after-free, reported here JuliaMath/FFTW.jl#261. In the future we will avoid all uses of deepcopy in Sunny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid all use of deepcopy SunnySuite/Sunny.jl
1 participant
@kbarros