Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lido #439

Open
JTraversa opened this issue Sep 6, 2022 · 3 comments
Open

Lido #439

JTraversa opened this issue Sep 6, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@JTraversa
Copy link
Contributor

JTraversa commented Sep 6, 2022

We had commented out Lido for some later considerations awhile back, and never re-introduced it.

Its 100% worth taking the bit of time to add Lido and ensure we're good to go for the next year or so.

That said, we need to address the three interfaces for integrations:

  1. deposit -- wrap
  2. withdraw -- unwrap
  3. exchangeRate -- getStETHByWstETH

Alex generally likes having supplyRatePerBlock to calculate APY as well, but I'm fairly sure that supplyRate will be extremely difficult to extrapolate. Its easy enough now, but varies based on tips/MEV post merge...

Other notes:

The underlying is not ETH or WETH, but stETH for wstETH.

So we can assume users have stETH ahead of time, or can write a wrapper that converts ETH->stETH through curve?

@JTraversa JTraversa added the enhancement New feature or request label Sep 6, 2022
@robrobbins
Copy link
Contributor

  1. i'll start on the integrations
  2. worry about supplyRate in a sep thing

@JTraversa
Copy link
Contributor Author

ah and for the underlying in one of those compounding libs, it can be hardcoded to 0xae7ab96520de3a18e5e111b5eaab095312d7fe84 (stETH)

@robrobbins
Copy link
Contributor

oh, ic. ok. lemme look at the best place for that.

was just reading the whole:

_stETHAmount must be non-zero
msg.sender must approve at least _stETHAmount stETH to this contract.
msg.sender must have at least _stETHAmount of stETH.```

for wrap...

@robrobbins robrobbins mentioned this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants