Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique scss file names (The "root_sass" paths need to end with unique filenames.) #82

Open
smepti opened this issue Jan 28, 2025 · 3 comments

Comments

@smepti
Copy link

smepti commented Jan 28, 2025

First of all, thanks a lot for this package!
There is a question - there is a validation that prohibits naming scss files the same way, even if they are in different folders. (https://github.com/SymfonyCasts/sass-bundle/blob/main/src/DependencyInjection/SymfonycastsSassExtension.php#L82)
We have a large project, thousands of scss files, and we have times when the file is called just index.scss
Is this limitation justified by something, or is it a groundwork for something that can be improved? Or are we doing something wrong and should we name the files uniquely? Thank you.

@krovorgen
Copy link

yeah, we encountered the same problem

@suppertoha
Copy link

Our team has the same problem

@bocharsky-bw
Copy link
Member

Hey there! The current implementation for processing those files requires you to have unique file names, IIRC that's because all those files are dumped to the same directory in public/. I don't remember any blockers that would stop us from fixing this issue, so if you want to give it a try and create a PR - go for it, it would be much appreciated. I suppose the final dumped file name should include the dir as well, the only possible problem I see so far is with long names when the path has many nested folders. Or probably it would be enough to prepend the name of the last folder only instead of following the full path in many folders. I'm open to any suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants