Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging permanently disabled in SBOLFactory() #77

Open
jharwell opened this issue Mar 16, 2023 · 0 comments
Open

logging permanently disabled in SBOLFactory() #77

jharwell opened this issue Mar 16, 2023 · 0 comments

Comments

@jharwell
Copy link

Unless invoked with verbose=True, the SBOLFactory() class permanently disables INFO,DEBUG logging after it is called, which means that anything using it can't use logging unless it does : logging.disable(logging.NOTSET) first. This either needs to be documented, or (much better) fixed. I see 3 potential fixes:

  1. Add the logging.disable(logging.NOTSET) at the end of the __new__() function to restore previous state
  2. Remove the logging.disable(logging.INFO) at the start of __new__() and instead change the level of all handles attached to LOGGER to be ERROR rather than INFO. This would serve the same purpose: disable status messages printed as the factory runs.
  3. Change all the INFO messages to be DEBUG so they do not print when the level is set to INFO (which is what most applications set it at).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant