Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on using mpv discord rpc plugin #651

Closed
gsk143 opened this issue Dec 2, 2023 · 3 comments
Closed

Crash on using mpv discord rpc plugin #651

gsk143 opened this issue Dec 2, 2023 · 3 comments
Labels
bug / problem External bug Problem lies outside of Syncplay code.

Comments

@gsk143
Copy link

gsk143 commented Dec 2, 2023

Describe the bug
Application crashes when using discord RPC https://github.com/tnychn/mpv-discord

Version and platform:

  • OS: Windows 11 64-bit
  • Syncplay version and build type: Syncplay 1.7.0
  • Media player and version: mpv v0.36.0-824-g7cab30ce

This can very well be the plugin issue but wonder if something can done here
image

@Et0h
Copy link
Contributor

Et0h commented Dec 2, 2023

Discord RPC seems to rely on IPC and as such I think this might be related to the issue at #529 and iamkroot/trakt-scrobbler#266

I am not aware of any satisfactory solution to that issue from 2022, and this seems like it could be considered an upstream limitation of mpv.

One potential workaround is for someone to add rich presence to Syncplay. Someone requested this at #491 back in October 2021 but to date nobody has volunteered to implement it .

@Et0h Et0h added the External bug Problem lies outside of Syncplay code. label Dec 2, 2023
@Et0h
Copy link
Contributor

Et0h commented Feb 3, 2024

The latest development build of Syncplay now creates a new IPC socket called mpvSyncplaySocket or \.\pipe\mpvSyncplaySocket that you can connect to with mpv-discord, or you can specify a different socket to use with by specifying a input-ipc-server player argument in Syncplay. See: https://github.com/Syncplay/syncplay/actions/runs/7766691704

So you should hopefully be able to get it to work with mpv and this version of Synplay by setting socket_path in /script-opts
/discord.conf to the Syncplay IPC socket.

@gsk143 Please test it and let me know if it works.

@Et0h
Copy link
Contributor

Et0h commented Apr 29, 2024

From Syncplay 1.7.3 the user will need to specify the pipe name (e.g. input-ipc-server=\\.\pipe\examplepipe) to connect to an mpv pipe. See #674 and #675 for details.

@Et0h Et0h closed this as completed Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / problem External bug Problem lies outside of Syncplay code.
Projects
None yet
Development

No branches or pull requests

2 participants