Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ [FIX]μ‚¬μš©μž νŽ˜μ΄μ§€ μ œμž‘ 마무리 (1) #132

Open
6 tasks done
chunzhi23 opened this issue Jan 21, 2025 · 6 comments
Open
6 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@chunzhi23
Copy link
Contributor

chunzhi23 commented Jan 21, 2025

Describe Existing Problem ❓

λͺ¨λ“  PR 머지λ₯Ό μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€.
ν˜„μž¬ develop 브랜치의 μ‚¬μš©μž νŽ˜μ΄μ§€μ—μ„œ λ°œμƒν•˜λŠ” 였λ₯˜μ™€ 보완사항을 역할을 λ‚˜λˆ„μ–΄ μ •μ •ν•©λ‹ˆλ‹€.

μ•„λž˜μ™€ 같이 λ‹€λ₯Έ νŒ€μ› ν•œ λͺ…이 맑은 νŽ˜μ΄μ§€λ₯Ό λ‹΄λ‹Ήν•©λ‹ˆλ‹€.

@chqkq

  • μž‘νŽ˜μ–΄ (μ„ λ°°λ‹˜λ“€μ˜ μ‘°μ–Έ, μΈν„΄λ“€μ˜ 이야기, μ±„μš©ν¬μ§€μ…˜)
  • s-top μ„€λͺ…
  • μ‚°ν•™ μ„€λͺ…
  • 과제 μ œμ•ˆ
  • κ³Όμ œμ œμ•ˆ 등둝

Describe Solution πŸ’Έ

μ‚¬μš©μž νŽ˜μ΄μ§€ μ΅œμ’… μ™„

Describe Alternatives πŸ’Ό

No response

CheckList βœ”οΈ

  • κ΄€λ ¨ Issue κ°€ 이미 μ‘΄μž¬ν•˜λŠ” 지 ν™•μΈν•΄λ³΄μ…¨λ‚˜μš”?
@chunzhi23 chunzhi23 added the enhancement New feature or request label Jan 21, 2025
@chunzhi23 chunzhi23 self-assigned this Jan 21, 2025
@chunzhi23
Copy link
Contributor Author

chunzhi23 commented Jan 21, 2025

μž‘νŽ˜μ–΄

μ„ λ°°λ‹˜λ“€μ˜ μ‘°μ–Έ

  • 47번 쀄 console.log μ§€μš°κΈ°

  • embed-player 였λ₯˜

    • 였λ₯˜ 세뢀사항을 λ³΄λ‹ˆ https://googleads.g.doubleclick.net/pagead/id μ΄λΌλŠ” url이 λ‚˜μ™€μžˆλŠ”λ° μ•„λ§ˆλ„ 유튜브 κ΄‘κ³  κ΄€λ ¨ 문제인 것 κ°™μ•„ λ³΄μž…λ‹ˆλ‹€. ν•΄κ²°ν•  수 μžˆλ‹€λ©΄ μ’‹κ² μ§€λ§Œ 없어도 큰 상관은 μ—†λŠ” 였λ₯˜μΌ λ“― ν•΄μš”!

Image

  • λ°°κ²½κ³Ό footer λ°°κ²½ 색 κ΅¬λ³„ν•΄μ£Όμ„Έμš”! λ‹€λ₯Έ νŽ˜μ΄μ§€λ₯Ό μ°Έκ³ ν•˜λ©΄μ„œ color λ³€μˆ˜ μ“°λ©΄ 될 것 κ°™μ•„μš”

  • μ˜΅μ…˜ initial '연도 선택'μ—μ„œ '전체'둜 μˆ˜μ •ν•΄μ£Όμ„Έμš”!

Image

  • μ˜μƒ 뢁마크 반영 μ•ˆ 되고 ν€΄μ¦ˆ ν’€κΈ° 였λ₯˜κ°€ λœΉλ‹ˆλ‹€!

    • λΆλ§ˆν¬λŠ” page.tsxμ—μ„œ λ°”λ€Œμ—ˆμ„ λ•Œ μž‘λ™ν•  ν•¨μˆ˜λ₯Ό λ§Œλ“€κ³  μ»΄ν¬λ„ŒνŠΈμ— λ„˜κ²¨μ€˜μ•Όν•  κ±°μ˜ˆμš”

    • ν€΄μ¦ˆν’€κΈ°λŠ” μ»΄ν¬λ„ŒνŠΈ 였λ₯˜μΈ 것 같은데 @moony1204 λ¬Έμ˜ν•΄μ£Όμ„Έμ—¬

  • κΈ°λ³Έ margin을 μ μš©ν•΄μ£Όμ„Έμš”! widthκ°€ μž‘μ•„μ§€λ‹ˆκΉŒλŠ” λ”± λΆ™μ–΄λ²„λ¦¬λ”λΌκ΅¬μš”

Image

μΈν„΄λ“€μ˜ 이야기

  • 44번 쀄 console μ§€μš°κΈ°

  • Videocard props둜 keyλ₯Ό λ°›λŠ”λ° keyλŠ” propsκ°€ μ•„λ‹ˆκΈ° λ•Œλ¬Έμ— 받지 μ•Šμ•„λ„ λ©λ‹ˆλ‹€! κ·Έλž˜μ„œ @moony1204 propsμ—μ„œ keyλ₯Ό 빼달라고 μš”μ²­ν•˜μ‹œλ©΄ λ κΊΌμ—μš”

Image

  • μœ„μ™€ λ™μΌν•˜κ²Œ λ°°κ²½κ³Ό footer 색상 κ΅¬λΆ„ν•΄μ£Όμ‹œκ΅¬
  • μ–‘μͺ½ μ΅œμ†Œ margin 보μž₯ν•΄μ£Όμ‹œκ΅¬
  • μ˜΅μ…˜ '연도 선택'μ—μ„œ '전체'둜 initial μƒνƒœ λ³€κ²½ν•΄μ£Όμ„Έμš”

Image

μ±„μš© ν¬μ§€μ…˜

  • 색상 λ³€κ²½ν•΄μ£Όμ‹œκ΅¬

  • μ΅œμ†Œ margin은 μžˆλŠ”λ° μ„Έλ‘œ gap이 μ—†μ–΄μ„œ μΆ”κ°€ν•΄μ£Όμ„Έμš”!

Image

@chunzhi23
Copy link
Contributor Author

μ‚°ν•™ μ„€λͺ…

λ§Œλ“€μ–΄μ£Όμ„Έμš”!

@chunzhi23
Copy link
Contributor Author

chunzhi23 commented Jan 21, 2025

과제 μ œμ•ˆ

  • λ°°κ²½ μ„€μ • μ‘°μ •ν•΄μ£Όμ„Έμš”!

  • to @chunzhi23 졜근이 μ•žμœΌλ‘œ μ˜€λ„λ‘ μˆ˜μ •! << 근데 이거 ν–ˆμ„ν…λ° μ΄μƒν•˜λ‹€

Image

  • 둜그인 μ•ˆ ν–ˆμ„ λ•Œ κΆŒν•œμ΄ 없을 λ•Œ νŽ˜μ΄μ§€λ₯Ό μ•„λž˜μ™€ 같이 λ³΄μ—¬μ£ΌλŠ”λ° μ—λŸ¬ λ‚˜μ˜€λ©΄ μ˜ˆμ•½λœ 말둜 보여주면 μ’‹κ² μ–΄μš”! 예λ₯Ό λ“€μ–΄ "둜그인 ν›„ 이용 κ°€λŠ₯ν•©λ‹ˆλ‹€"와 같은..? useAuth() hook μ‚¬μš©ν•΄μ„œ isLoggedIn λ°›μ•„μ˜€κ³  μ²˜λ¦¬ν•˜λ©΄ νŽΈν• κ±°μ—μš”!

Image

  • for @chunzhi23 ν•˜μœ„ νŽ˜μ΄μ§€λ‘œ μ΄λ™ν•˜μ§€ μ•Šκ²Œ, 이름 λ°”λ€Œκ²Œ!!

Image

@chunzhi23
Copy link
Contributor Author

chunzhi23 commented Jan 21, 2025

과제 μ œμ•ˆ 등둝

  • λ°°κ²½ 색상 μ‘°μ •ν•΄μ£Όμ„Έμš”!

Image

@2tle
Copy link

2tle commented Jan 22, 2025

μž‘νŽ˜μ–΄

μž‘νŽ˜μ–΄ ν€΄μ¦ˆ κ΄€λ ¨

μž‘νŽ˜μ–΄ μ˜μƒμ€ ν€΄μ¦ˆκ°€ μ—†λŠ” κ²ƒμœΌλ‘œ μ•Œκ³  μžˆμŠ΅λ‹ˆλ‹€.
(ν€΄μ¦ˆλŠ” λŒ€λ‹΄ μ˜μƒμ—λ§Œ 쑴재)
ν•΄λ‹Ή λ²„νŠΌμ€ μž‘νŽ˜μ–΄μ—μ„œ μ—†μ• μ•Ό ν• κ±° κ°™μŠ΅λ‹ˆλ‹€.

@chqkq
Copy link
Contributor

chqkq commented Jan 22, 2025

μž‘νŽ˜μ–΄

μž‘νŽ˜μ–΄ ν€΄μ¦ˆ κ΄€λ ¨

μž‘νŽ˜μ–΄ μ˜μƒμ€ ν€΄μ¦ˆκ°€ μ—†λŠ” κ²ƒμœΌλ‘œ μ•Œκ³  μžˆμŠ΅λ‹ˆλ‹€. (ν€΄μ¦ˆλŠ” λŒ€λ‹΄ μ˜μƒμ—λ§Œ 쑴재) ν•΄λ‹Ή λ²„νŠΌμ€ μž‘νŽ˜μ–΄μ—μ„œ μ—†μ• μ•Ό ν• κ±° κ°™μŠ΅λ‹ˆλ‹€.

λ²„νŠΌ μ—†λŠ” videoCard μƒˆλ‘œ λ§Œλ“€μ–΄μ„œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€!

moony1204 added a commit that referenced this issue Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants