Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server dockerization #121

Closed
Tracked by #142
bnonni opened this issue Aug 28, 2024 · 10 comments · Fixed by #146
Closed
Tracked by #142

Server dockerization #121

bnonni opened this issue Aug 28, 2024 · 10 comments · Fixed by #146
Assignees
Labels
cicd Related to devops in some way (github actions, docker, etc)) good first issue Good for newcomers hacktoberfest 2024 Related to hacktoberfest 2024 help wanted Extra attention is needed package: server Directly impacts the server package

Comments

@bnonni
Copy link
Contributor

bnonni commented Aug 28, 2024

To enable easy local development, it would be ideal to include dockerfiles and a docker-compose file in the server package. The goal is to containerize the whole stack (issuer and applicant servers) as well as a local dwn so users could easily install the server package, run the docker stack and develop locally against that.

@bnonni bnonni added good first issue Good for newcomers package: server Directly impacts the server package labels Aug 28, 2024
@bnonni bnonni changed the title Server dev env Server dockerization Aug 28, 2024
@bnonni bnonni added cicd Related to devops in some way (github actions, docker, etc)) hacktoberfest 2024 Related to hacktoberfest 2024 help wanted Extra attention is needed labels Aug 28, 2024
@adalundhe
Copy link
Contributor

I’ll grab this one for y’all if you’re open to it! ❤️ Would Devcontainers be solid, or are y’all thinking just Docker Compose + Docker?

@adalundhe
Copy link
Contributor

.take

Copy link

Thanks for taking this issue! Let us know if you have any questions!

@adalundhe
Copy link
Contributor

I'm working on the .devcontainer setup over here!

https://github.com/adalundhe/incubation-dcx/tree/AL-add-devcontainer-env

Should have a draft PR up shortly. ❤ Let me know if there's anything additional we'd like in the NodeJS devcontainer - for now it's a relatively complete version of the usual Devcontainer I use for my own projects minus unecessary fluff like the awscli. It does include nice things like the gh cli, bash completion, etc!

@blackgirlbytes
Copy link
Collaborator

worddd this is looking good ❤ appreciate you, Ada!!!

@adalundhe
Copy link
Contributor

@adalundhe
Copy link
Contributor

adalundhe commented Oct 18, 2024

PR is up here!

#146

Let me know if there's anything y'all run into in testing or any tweaks y'all would like (preference or otherwise)! I'm happy to do it all! ❤

@blackgirlbytes
Copy link
Collaborator

WHOOOOOOOO! thank you @adalundhe!

@blackgirlbytes blackgirlbytes linked a pull request Oct 22, 2024 that will close this issue
@bnonni
Copy link
Contributor Author

bnonni commented Oct 22, 2024

@adalundhe thank you so much for this PR! Well done!

@bnonni
Copy link
Contributor Author

bnonni commented Oct 22, 2024

Completed by #146

@bnonni bnonni closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Related to devops in some way (github actions, docker, etc)) good first issue Good for newcomers hacktoberfest 2024 Related to hacktoberfest 2024 help wanted Extra attention is needed package: server Directly impacts the server package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants