Instructor's Student Records Page: Misleading name for canceling of comment edit

[weiquu]

When editing a comment, the button for cancelation of editing is named "Discard", which is quite misleading - my instinct would be to assume that this deletes the comment entirely, rather than "discarding" the edit:

Possibly a better wording would be Cancel, as is common in other website (e.g. Github):

In a similar vein, pressing "Save" even when no edits have been made to a comment causes the comment to show up as edited - I'm not sure if this behaviour is intended or intuitive. Open to discussion.

The delete icon on the comment might also be better in red?

[github-actions]

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

[abdqudus]

Can I take this issue

[cedricongjh]

hi @abdqudus feel free to submit a PR

[abdqudus]

Should I just use "discard changes"? The button text is a ternary operator that either reads "Discard" or "Cancel" . I think making the button text "Cancel" wouldn't be that good?

[cedricongjh]

hi @abdqudus I think we that should stick to "Cancel" as suggested by @weiquu, as is common in most websites

[abdqudus]

Oh,Ok