-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attachment of nested steps incorrectly rendered in html report #1131
Comments
Hi adrian-herscu, thanks for reporting the issue. Now that we are back from our holidays, I will get to it immedeately. At first glance it appears that this is an issue with the HTML-App. In this case fixing this would take a bit, because we're of the opinion that the HTML-App needs to be replaced and we are working towards that goal. This brings me to my final question. Are the attachements [2] and [3] always copies of [1]? Or are they only copies if you introduce the dummy step. Furthermore, in case they are duplicates, do they appear as duplicates in the json, or only in the display? |
[2] does not appear without the dummy step and [3] is a copy, yes. |
Hope that the new report will work without JavaScript/CSS/custom fonts -- there are managed Jenkins instances which restrict these :( |
I got around to verifying that this issue at least exists solely within the HTML app. The json report is rendered correctly in my test case: https://github.com/TNG/JGiven/tree/fix/Issue-1131-wron-attachment-handling |
Consider a scenario with Nested Steps:
a. First Nested Step with attachment [2]
b. Second Nested Step with attachment [3]
The resulting report should contain 3 different attachments.
The actual report contains only 2 attchaments, although all 3 attachments appear in json report file.
If we would add a dummy step before 2.a step, then 3 attachments appear, however the [2] and [3] attachments are just copies of [1] attachment.
Checked with 1.1.0 and with 1.2.4.
The text was updated successfully, but these errors were encountered: