Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 Hour Time Added to Preferences and Functionality #1063

Closed
wants to merge 2 commits into from

Conversation

jackw00
Copy link

@jackw00 jackw00 commented Feb 5, 2024

Related issue

Closes #10

Context / Background

  • The purpose of this PR is to add a button on the preferences page that allows users to switch back and forth from 24 hour time mode to 12 hour AM/PM mode. When in 24 hour time mode the monthly calendar appears the same as in 12 hour time mode, except users can enter their time in 24 hour format, and don't have the option to select AM/PM.

What change is being introduced by this PR?

  • Added a button on preferences HTML and js. Based on preferences, a different validate time function in time-math.js is called for 24 hour time. Based on preferences, the HTML (loaded via JavaScript) and JavaScript in base calendar and monthly calendar loads a different input box and fetches the input from these input boxes using a different label.

How will this be tested?

  • Built in test cases. Added test case for changing to 24 hour time.

@jackw00 jackw00 marked this pull request as ready for review February 5, 2024 01:07
@tupaschoal
Copy link
Collaborator

Hi @jackw00, thanks for your contribution as your first PR?
Would you mind posting a short gif/video showing how the feature works now?

@araujoarthur0
Copy link
Collaborator

Ping @jackw00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of 12/24 hour day
3 participants