Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write example Jupyter Notebook RadarCoding Toolbox #1

Open
alapadat1 opened this issue Jan 7, 2025 · 3 comments
Open

Write example Jupyter Notebook RadarCoding Toolbox #1

alapadat1 opened this issue Jan 7, 2025 · 3 comments
Assignees

Comments

@alapadat1
Copy link
Collaborator

No description provided.

@alapadat1 alapadat1 self-assigned this Jan 7, 2025
@alapadat1
Copy link
Collaborator Author

@alapadat1
Copy link
Collaborator Author

@rogerkuou, @FreekvanLeijen
could you please check the notebook?
I added the expected results on figshare: https://figshare.com/articles/dataset/nl_limburg_s1_results_zip/28195322?file=51641261

@rogerkuou
Copy link
Member

Hi @alapadat1, thx! I checked the notebook. In general I think the content is clear! I just have a few general comments in the documentation and the way of working.

  1. I see you already uploaded the notebook to the main. Maybe next time consider work on a branch, add the notebook on the branch first, and make a PR for review? In general the issue here is mainly used for discussions, i.e. stuff not planned to be put in a repo.
  2. Your notebook description cells uses Markdown format. You can think of using this feature for a better rendering/formatting of your notebook. For example you can use single/double/triple hastags for titles, make lists, add hyperlinks to texts. These all increase the readbility.
  3. I quite like your way of sharing the results. Just currently they are a bit hidden in your descriptions. Maybe we can have some hyperlinks/descriptions to it at the beginning?

Apart from the comments above, I am good with this notebook. Feel free to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants