Missing <annotation> for GML ReferenceType

[yaozhihang]

The property connectedCityObject of the class AbstractNetworkFeature has a type of gml:ReferenceType
https://github.com/TatjanaKutzner/CityGML-UtilityNetwork-ADE/blob/master/XSD/CityGML_UtilityNetworkADE.xsd#L119
An annotation element is usually required here which allows applications to know what is the target element. For example:

<element minOccurs="0" name="connectedCityObject" type="gml:ReferenceType">
  <annotation>
    <appinfo>
      <gml:targetElement>core:_CityObject</gml:targetElement>
    </appinfo>
  </annotation>
</element>

Could be a bug in ShapeChange? Or something is missing the shapechange configuration file?

[TatjanaKutzner]

The element gml:targetElement is part of the GML 3.2 encoding rule. It does not exist in GML 3.1.1. Since the ADE is based on CityGML 2.0, which in turn uses GML 3.1.1., ShapeChange behaves correctly in not adding this element.

The GML 3.1.1. standard, however, defines the following encoding for specifying the target element:

<element name="owner" type="gml:ReferenceType" minOccurs=”0”>
  <annotation>
    <appinfo source=”urn:x-gml:targetElement”>_CityObject</appinfo>
  </annotation>
</element>

This kind of annotation does not seem to be supported by ShapeChange.

[yaozhihang]

Thanks, you are right. It seems that adding gml:targetElement to CityGML 2.0 ADE is not a correct and valid way.
So, maybe the EnergyADE (http://www.citygmlwiki.org/images/a/ac/EnergyADE.xsd) XML schema shall be fixed accordingly.

[TatjanaKutzner]

I posted an issue in the Energy ADE repository to find out why the made use of the element: https://git.rwth-aachen.de/energyade/citygml-energy/-/issues/173