Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible porting error with Stalactite generation #2235

Open
Andromander opened this issue Aug 25, 2024 · 0 comments
Open

Possible porting error with Stalactite generation #2235

Andromander opened this issue Aug 25, 2024 · 0 comments

Comments

@Andromander
Copy link
Member

NeoForge version: 20.6.116
Twilight Forest version: whatever version we left 1.20.6 at

I've been doing a bit of extensive research into Stalactites for their contents, and I realised there's conflicting information, that being screenshots and what's currently generating.

The main point I've noticed is that Hydra Lairs used to generate Lapis Lazuli, Diamond, and Emerald Ores. I don't know if it was agreed upon to remove the ores, but if it wasn't, this is likely a porting error. Based on some code I've been scavenging from 1.7.10, ores from the next hill size up were able to generate, though at a much lower chance than if it were the exact size. Since the Hydra Lair's hill size in code is 2, this meant that hill size 3 ores had a 1 in 5 chance of attempting to generate. In the current stalactite config, this is not the case, as these ores are not able to generate (aside from circumstantial worldgen).

As an aside while I was looking through this, I'm not sure the stalactite configs accurately represent the chance they're allowed to generate, based on 1.7.10's logic. I might not be looking at the code correctly, so that might just be a me issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant