Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog compat with Bumblezone #453

Open
SanQianQVQ opened this issue Oct 22, 2024 · 2 comments
Open

Fog compat with Bumblezone #453

SanQianQVQ opened this issue Oct 22, 2024 · 2 comments
Labels
Mod Compat Issue is caused with another mod being on or compat with another mod

Comments

@SanQianQVQ
Copy link

https://github.com/IMB11/Fog

When Bumblezone and Fog are used, the fog color is written by FOG. Can you provide the fog color code of Bumblezone in order to write compatible packets

_S})03 E2MIU)A8JAZ3V4NG

@TelepathicGrunt
Copy link
Owner

What exactly do you mean by compatibility packets? This would not need networking packet code. This is all clientside code.

I think you should ask the FOG dev to add a config (if one does not exist yet) to allow users to specify biomes or dimensions to not modify the fog of. I suspect FOG is being invasive with its changes and will break any mod that tries to handle fog for their own use cases. Such as Vampirism and my mod here.

In fact, my mod’s fog color is simply using the vanilla dimension fog color method here. So it seems this FOG mod also possibly breaks datapack dimensions too that specify fog color (or at least breaks any mods overriding this method)

public Vec3 getBrightnessDependentFogColor(Vec3 color, float sunHeight) {

@TelepathicGrunt TelepathicGrunt added the Mod Compat Issue is caused with another mod being on or compat with another mod label Oct 22, 2024
@SanQianQVQ
Copy link
Author

兼容性数据包到底是什么意思?这不需要网络数据包代码。这都是客户端代码。

我认为您应该要求 FOG 开发人员添加一个配置(如果尚不存在)以允许用户指定不修改雾的生物群落或维度。我怀疑 FOG 的更改具有侵入性,并且会破坏任何试图为自己的用例处理雾的 Mod。比如 Vampirism 和我在这里的 Mod。

事实上,我的 Mod 的雾颜色在这里只是使用了原版维度雾的颜色方法。所以看起来这个 FOG mod 也可能破坏指定雾颜色的数据包维度(或者至少破坏了覆盖此方法的任何 mod)

public Vec3 getBrightnessDependentFogColor(Vec3 color, float sunHeight) {

https://docs.imb11.dev/fog/fog-definitions here
I checked the wiki of fog, it seems to be realized through the form of a resource package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod Compat Issue is caused with another mod being on or compat with another mod
Projects
None yet
Development

No branches or pull requests

2 participants