Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draggableAt is Not Working #168

Open
anliting opened this issue Jul 26, 2024 · 10 comments
Open

draggableAt is Not Working #168

anliting opened this issue Jul 26, 2024 · 10 comments

Comments

@anliting
Copy link

anliting commented Jul 26, 2024

draggableAt of the following example does not work on my device:
https://github.com/Temzasse/react-modal-sheet/blob/HEAD/example/components/ScrollableSnapPoints.tsx
https://temzasse.github.io/react-modal-sheet/#/scrollable-snap-points

What I expected is that, when the content is scrolled to top, the sheet is draggable.

@shivaluma
Copy link

did you manage to have a workaround ?

@anliting
Copy link
Author

anliting commented Oct 9, 2024

did you manage to have a workaround ?

No, I did not.

@carlos-ribeiro-zup
Copy link

This is pretty annoying. The drag action is only working on web browser when no device view is applied.
Thinking of create a fork just to fix that problem and others already opened on pull requests.

@Temzasse
Copy link
Owner

Hey everybody! 👋🏻

Chiming in here: the draggability is not super reliable on non-touch devices and I recommend testing it with a iOS/Android simulator instead of in Chrome's mobile emulation mode.

@carlos-ribeiro-zup I'm very much open to PRs to improve the draggability/scrollability 😊

@carlos-ribeiro-zup
Copy link

Thanks for replying @Temzasse. As the issues and PRs were opened too many days ago, I thought you've kind abandoned the lib. Glad it's not, cuz you did a really nice job here.

@Temzasse
Copy link
Owner

Thanks @carlos-ribeiro-zup 👍🏻

I haven't abandoned the lib but I'm definitely much more busy nowadays so it's hard to find time to work on open source stuff 😞 Every now and then I get an energy boost and try to tackle multiple issues at once 😄

@alexkates
Copy link

Anyone working on a fix for this yet? just ran into it as well.

@carlos-ribeiro-zup
Copy link

Anyone working on a fix for this yet? just ran into it as well.

As @Temzasse have mentioned here.

This issue could be closed.

@alexkates
Copy link

You're right. Confirming after testing https://temzasse.github.io/react-modal-sheet/#/scrollable-snap-points on my iPhone simulator that it works as intended. Thanks!

@shivaluma
Copy link

shivaluma commented Nov 13, 2024

After testing, I found that it works perfectly on iOS, but not on Android. I had to use vaul as an alternative solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants